Removes unused GlToast from container registry bundle
What does this MR do and why?
The code removes import of GlToast
component from both the container registry explorer and the harbor registry explorer.
This is not used anymore.
Closes #507399 (closed)
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @rchanila
added frontend groupcontainer registry maintenancerefactor labels
added typemaintenance label
added devopspackage sectionci labels
changed milestone to %17.7
added pipelinetier-1 label
1 Warning This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/packages_and_registries/container_registry/explorer/index.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/packages_and_registries/container_registry/explorer/index.js'
Reviewer roulette
Category Reviewer Maintainer frontend @lwanko
(UTC+1, 10 hours behind author)
@xanf
(UTC+2, 9 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 60e417ea and ae5c5f02
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.48 MB 4.48 MB - -0.0 % mainChunk 3.37 MB 3.37 MB - 0.0 % Significant Reduction: 4Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.harbor.repositories 594.54 KB 569.18 KB -25.37 KB -4.3 % pages.groups.registry.repositories 766.51 KB 741.15 KB -25.37 KB -3.3 % pages.projects.harbor.repositories 567.3 KB 541.94 KB -25.37 KB -4.5 % pages.projects.registry.repositories 739.27 KB 713.9 KB -25.37 KB -3.4 %
Note: We do not have exact data for 60e417ea. So we have used data from: 914d48e3.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Zack Cuddy
@zcuddy can you please do the maintainer review here? Skipping initial review since this is straightforward.
requested review from @zcuddy
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8522910986 spec/features/projects/container_registry_spec.rb#L140
Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.34 s < 50.13 s #8522910986 spec/features/projects/container_registry_spec.rb#L155
Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 54.13 s < 50.13 s - A deleted user
added rspec:slow test detected label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ae5c5f02expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 25 | 0 | 11 | 0 | 36 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 403 | 0 | 41 | 0 | 444 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for ae5c5f02expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added Category:Container Registry label
started a merge train
mentioned in commit 655a9293
mentioned in issue #507399 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label