Remove group branch modification setting ff

What does this MR do and why?

Remove group branch modification setting

• remove 'scan_result_policy_block_group_branch_modification' feature flag everywhere
• update tests
• update mocks in integration tests

Changelog: other

EE: true

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Scenario	Screenshot
search for scan_result_policy_block_group_branch_modification ff
search for scanResultPolicyBlockGroupBranchModification ff
Policy editor - Project
Policy editor - Group
Policy drawer
Protected branches

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

1. Upload a GitLab Ultimate license
2. Navigate to a top-level group => Secure => Policies => New policy => Merge request approval policy
3. Verify the Block group branch modification setting shows and can be toggled and modified, enable it
4. Create the policy
5. Navigate to the top-level-group => Settings => Repository => Protected Branches
6. Verify branches are protected

Related to #503930 (closed)

changed milestone to %17.7

added Category:Security Policy Management GitLab Ultimate analytics instrumentation devopssecurity risk management feature flag featureaddition frontend groupsecurity policies sectionsec typefeature workflowready for development labels

assigned to @aturinske

added pipelinetier-1 label

added backend label

	1 Message
	This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

Documentation review

The following files require a review from a technical writer:

• doc/user/application_security/policies/merge_request_approval_policies.md (Link to current live version)

The review does not need to block merging this merge request. See the:

• Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
• The Technical Writer assigned for that stage and group.
• Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@thutterer (UTC+5.5, 13.5 hours ahead of author)	@digitalmoksha (UTC-6, 2 hours ahead of author)
frontend	@drosse (UTC+0, 8 hours ahead of author)	@jerasmus (UTC+1, 9 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 406804d8 and 6919a408

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.48 MB	4.48 MB	-1.37 KB	-0.0 %
mainChunk	3.37 MB	3.37 MB	-	0.0 %

Significant Reduction: 11

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.admin.gitlab_duo.seat_utilization	853.28 KB	800.85 KB	-52.43 KB	-6.1 %
pages.admin.gitlab_duo.show	898.55 KB	846.12 KB	-52.43 KB	-5.8 %
pages.groups.settings.gitlab_duo.seat_utilization	978.31 KB	925.88 KB	-52.43 KB	-5.4 %
pages.groups.settings.gitlab_duo.show	1012.89 KB	960.46 KB	-52.43 KB	-5.2 %
pages.gitlab_subscriptions.trials.create	336.04 KB	283.97 KB	-52.07 KB	-15.5 %
pages.gitlab_subscriptions.trials.duo_enterprise.new	336.3 KB	284.23 KB	-52.07 KB	-15.5 %
pages.gitlab_subscriptions.trials.duo_pro.new	336.28 KB	284.21 KB	-52.07 KB	-15.5 %
pages.gitlab_subscriptions.trials.new	336.18 KB	284.11 KB	-52.07 KB	-15.5 %
pages.registrations.company.new	111.56 KB	59.49 KB	-52.07 KB	-46.7 %
pages.users.identity_verification.show	829.23 KB	777.16 KB	-52.07 KB	-6.3 %

The table above is limited to 10 entries. Please look at the full report for more details

---

Note: We do not have exact data for 406804d8. So we have used data from: 51fe1d09.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

changed the description

added 1 commit

• 6919a408 - Remove group branch modification setting

Compare with previous version

@sashi_kumar can you review the backend?

@lorenzvanherwaarden can you review the frontend?

Thanks

requested review from @sashi_kumar and @lorenzvanherwaarden

added documentation label

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 6919a408

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
| Package     | 25     | 0      | 11      | 0     | 36    | ✅     |
| Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
| Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
| Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
| Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 403    | 0      | 41      | 0     | 444   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for 6919a408

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
| Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
| Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

requested review from @arfedoro

approved this merge request

approved this merge request

resolved all threads

enabled automatic add to merge train when checks pass

started a merge train

merged

mentioned in commit 4a9df899

added workflowstaging-canary label and removed workflowready for development label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-production label and removed workflowproduction label

changed title from Remove group branch modification setting to Remove group branch modification setting ff

added releasedcandidate label

mentioned in merge request !175423 (merged)

added releasedpublished label and removed releasedcandidate label