Issuable popovers: Migrate to subtle design token
What does this MR do and why?
Issuable popovers: Migrate to subtle
text design token
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Go to an issuable, add a reference in the editor to a e.g. MR or Issue
- Check the popover
Related to #499695 (closed)
Merge request reports
Activity
changed milestone to %17.7
assigned to @seggenberger
added devopsfoundations groupux paper cuts labels
- Resolved by Scott de Jonge
@sdejonge another small migration for you to have a look at
removed UX label
requested review from @sdejonge
added pipelinetier-1 label
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/issuable/popover/components/milestone_popover.vue
- <span class="gl-flex gl-text-secondary" data-testid="milestone-label"> + <span class="gl-flex gl-text-subtle" data-testid="milestone-label"> - <span v-if="showTimeframe" class="gl-text-secondary" data-testid="milestone-timeframe" + <span v-if="showTimeframe" class="gl-text-subtle" data-testid="milestone-timeframe"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @ccharnolevsky
(UTC+2, 1 hour ahead of author)
@tristan.read
(UTC+13, 12 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e045b5da and 45fcb9c6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.48 MB 4.48 MB - 0.0 % mainChunk 3.37 MB 3.37 MB - 0.0 %
Note: We do not have exact data for e045b5da. So we have used data from: 9f3659c0.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Sascha Eggenberger
requested review from @sdejonge
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 45fcb9c6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Package | 25 | 0 | 11 | 0 | 36 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 403 | 0 | 41 | 0 | 444 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 45fcb9c6expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 972bf287
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label