Skip to content
Snippets Groups Projects

Fix the spacing between trials title and text

Merged Doug Stull requested to merge 500689-fix-spacing into master
All threads resolved!

What does this MR do and why?

Fix the spacing between trials title and text

Changelog: other EE: true

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-11-25_at_8.25.25_AM Screenshot_2024-11-25_at_8.25.50_AM

How to set up and validate locally

  1. Setup GDK to simulate SaaS.
  2. Visit /-/trials/new.
  3. Notice the page.

Related to #500689

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    @katiemacoy can you please review UX?

  • added workflowin review label and removed workflowverification label

  • Doug Stull requested review from @katiemacoy

    requested review from @katiemacoy

  • Doug Stull requested review from @sheldonled

    requested review from @sheldonled

  • removed automation:ml label

  • A deleted user added backend frontend labels

    added backend frontend labels

  • 3 Warnings
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    :warning: The master pipeline status page reported failures in

    If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
    Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @squadri profile link current availability (UTC+0, 5 hours ahead of author) @reprazent profile link current availability (UTC+1, 6 hours ahead of author)
    frontend @ramistry profile link current availability (UTC+5.5, 10.5 hours ahead of author) @arfedoro profile link current availability (UTC+1, 6 hours ahead of author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Katie Macoy approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for a73b788c

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 402    | 0      | 41      | 0     | 443   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for a73b788c

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Doug Stull added 1 commit

    added 1 commit

    • a73b788c - Fix the spacing between trials title and text

    Compare with previous version

  • Sheldon Led resolved all threads

    resolved all threads

  • Sheldon Led approved this merge request

    approved this merge request

  • Sheldon Led enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Sheldon Led mentioned in commit 2c2c51ff

    mentioned in commit 2c2c51ff

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading