Fix sidebar buttons
What does this MR do and why?
Remove unexpected border from sidebar buttons
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to any issue, f.e. http://gdk.test:3000/flightjs/Flight/-/issues/7
- Collapse the right sidebar
Merge request reports
Activity
changed milestone to %17.7
added UX Paper Cuts groupdesign system typemaintenance labels
assigned to @jmiocene
- Resolved by Andrei Zubov
@clavimoniere
Could you please review UX here?
requested review from @clavimoniere
added Category:Design System devopsfoundations sectioncore platform labels
added pipelinetier-1 label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @tgao3701908
(UTC-5, 6 hours behind author)
@DylanGriffith
(UTC-6, 7 hours behind author)
frontend @ms.mondrian
(UTC-5, 6 hours behind author)
@andrei.zubov
(UTC+1, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ff2d7083 and 88aa9030
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.46 MB 4.46 MB - 0.0 % mainChunk 3.36 MB 3.36 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @seggenberger and removed review request for @clavimoniere
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 88aa9030expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 41 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 88aa9030expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Andrei Zubov
@andrei.zubov
Could you please do frontend and maintainer review here since it's a small UI change?
requested review from @andrei.zubov
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit f388e93e
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#9457 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label