Only highlight file on changes tab
Merge request reports
Activity
changed milestone to %17.7
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
added pipelinetier-1 label
- Resolved by Peter Hegman
@peterhegman Could you please review this fix?
requested review from @peterhegman
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @ccharnolevsky
(UTC+2, 2 hours ahead of author)
@mlunoe
(UTC+1, 1 hour ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger125 125 .vue-recycle-scroller__item-wrapper { 126 126 overflow: visible; 127 127 } 128 129 .diff-file { 130 &.diff-file-is-active, 131 &:has(*:not(textarea):focus-visible) { I don't actually know; this was a groupcode review feature. @mle Is this intentional?@annabeldunstone The focus on the active diff should have only been for the the Changes tab. Thanks for making the change.
Background is that if you are navigating multiple files using the keyboard shortcuts on the MR page or using the file tree, there wasn't any visual feedback to tell you what is currently active !137912 (comment 1972438941)
@mle But in this case, we're also focusing it when you click a button in the editor. Is that intentional? For example, look at the changes tab on this MR. If you focus one and click a button in the other, they're both highlighted:
Opened an MR with a fix and alternative proposal --> Update highlighted file styles (!173163 - merged)
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 42faf98a and ef183cab
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.41 MB 4.41 MB - 0.0 % mainChunk 3.32 MB 3.32 MB - 0.0 %
Note: We do not have exact data for 42faf98a. So we have used data from: fd744cdf.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in merge request !171670 (merged)
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ef183cabexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 41 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for ef183cabexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit c2faceca
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label