Skip to content
Snippets Groups Projects

Only highlight file on changes tab

Merged Annabel Dunstone Gray requested to merge outline-overview-tab into master
1 unresolved thread

What does this MR do and why?

Removes focus outline on diff comments on Overview tab

Screenshots or screen recordings

Before After
Screenshot_2024-11-18_at_3.06.29_PM Screenshot_2024-11-18_at_3.07.01_PM

How to set up and validate locally

  • Go to a merge request
  • Go to a diff comment on the overview tab
  • Click emoji button
  • No outline should appear

Links

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
125 125 .vue-recycle-scroller__item-wrapper {
126 126 overflow: visible;
127 127 }
128
129 .diff-file {
130 &.diff-file-is-active,
131 &:has(*:not(textarea):focus-visible) {
  • Peter Hegman approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Peter Hegman enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Peter Hegman resolved all threads

    resolved all threads

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 42faf98a and ef183cab

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.41 MB 4.41 MB - 0.0 %
    mainChunk 3.32 MB 3.32 MB - 0.0 %

    Note: We do not have exact data for 42faf98a. So we have used data from: fd744cdf.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Michael Le mentioned in merge request !171670 (merged)

    mentioned in merge request !171670 (merged)

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for ef183cab

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 402    | 0      | 41      | 0     | 443   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for ef183cab

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • merged

  • Peter Hegman mentioned in commit c2faceca

    mentioned in commit c2faceca

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading