Stick the line numbers left when scrolling
What does this MR do and why?
Adjust the line numbers so they remain visible while the code can still be scrolled horizontally. The line numbers would stay fixed, even when the code snippet is scrolled.
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
Screen_Recording_2024-11-13_at_14.12.07 | Screen_Recording_2024-11-13_at_14.23.05 |
How to set up and validate locally
- Go to Project --> Secure --> Vulnerability report --> Filter by tool=Gitlab Advanced SAST --> Select one that also have code flow
- Scroll the content left and right and validate the line numbers are still sticky left.
Numbered steps to set up and validate the change are strongly suggested.
Related to #497926 (closed)
Merge request reports
Activity
changed milestone to %17.7
assigned to @ccharnolevsky
added workflowin review label and removed workflowin dev label
added pipelinetier-1 label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @anastasia.khom
(UTC-5, 7 hours behind author)
@dpisek
(UTC+1, 1 hour behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f051afac and a66c4267
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.41 MB 4.41 MB - 0.0 % mainChunk 3.32 MB 3.32 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 486 commits
-
6917f5f6...bf9f4240 - 485 commits from branch
master
- a66c4267 - Stick the line numbers left when scrolling
-
6917f5f6...bf9f4240 - 485 commits from branch
requested review from @djadmin
- Resolved by Dheeraj Joshi
Hey @djadmin Can you do CR please?
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a66c4267expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 41 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 45ee7052
added workflowstaging-canary label and removed workflowin review label
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#9413 (closed)
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label