Skip to content
Snippets Groups Projects

Protected containers: Remove field "Minimum access level for delete"

1 unresolved thread
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do and why?

Protected containers: Remove field "Minimum access level for delete"

  • During rollout of the feature "Protected containers", we noticed that the field "Minimum access level for delete" is visible, but the aspect delete protection has not been implemented yet; therefore, the existence / visibility of the field "Minimum access level for delete" might lead to unnecessary confusion.
  • This MR intends to remove the field "Minimum access level for delete" from the frontend as suggested here: #480385 (comment 2193605295)

:tools: with :heart: at Siemens

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

MR Checklist (@gerardo-navarro)

Screenshots or screen recordings

This MR removes the field Minimum access level for delete because the delete protection feature is not implemented yet.

Before After
image image

How to set up and validate locally

  1. Go to the registry settings of a project: http://gdk.test:3000/flightjs/Flight/-/settings/packages_and_registries

Related to #480385 (closed)

Edited by Gerardo Navarro

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rahul Chanila
  • Rahul Chanila approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • 1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Category Reviewer Maintainer
    frontend @cindy-halim profile link current availability (UTC-5) @justin_ho profile link current availability (UTC+1)
    UX @pedroms profile link current availability (UTC+0) Maintainer review is optional for UX

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Rahul Chanila requested review from @justin_ho and removed review request for @rchanila

    requested review from @justin_ho and removed review request for @rchanila

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 2f76b6e0 and f0fe6107

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.41 MB 4.41 MB - -0.0 %
    mainChunk 3.32 MB 3.32 MB - 0.0 %

    Note: We do not have exact data for 2f76b6e0. So we have used data from: 00c39369.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #8342425561 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.75 s < 50.13 s
    #8342425561 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 52.36 s < 50.13 s
    #8346784349 spec/features/projects/container_registry_spec.rb#L140 Container Registry with metadatabase enabled when there are image repositories image repo details user removes a specific tag from container repository 63.82 s < 50.13 s
    #8346784349 spec/features/projects/container_registry_spec.rb#L155 Container Registry with metadatabase enabled when there are image repositories image repo details pagination navigate to the second page 53.68 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for f0fe6107

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 402    | 0      | 41      | 0     | 443   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for f0fe6107

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Govern      | 84     | 0      | 9       | 3     | 93    | ✅     |
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Verify      | 50     | 0      | 15      | 0     | 65    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 1      | 0      | 6       | 0     | 7     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Sascha Eggenberger approved this merge request

    approved this merge request

  • Marcel Amirault approved this merge request

    approved this merge request

  • Hi @marcel.amirault :wave:,

    GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.

    This message was generated automatically. Improve it or delete it.

  • Justin Ho Tuan Duong approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong resolved all threads

    resolved all threads

  • Justin Ho Tuan Duong enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • mentioned in commit 87ea3a82

  • added workflowstaging label and removed workflowcanary label

  • Rahul Chanila mentioned in commit bc69764a

    mentioned in commit bc69764a

  • Rahul Chanila mentioned in merge request !174642 (merged)

    mentioned in merge request !174642 (merged)

  • Rahul Chanila mentioned in commit 9b66e020

    mentioned in commit 9b66e020

  • Rahul Chanila mentioned in commit a915ff35

    mentioned in commit a915ff35

  • Please register or sign in to reply
    Loading