Create todos for expiring and expired SSH keys

What does this MR do and why?

This removes the derisk feature flag that was still in place.

With that removed, expiring and expired SSH keys now create todo items for the key owner.

Deployed and verified on production on Nov 5 and 6.

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

• [Feature flag] Rollout of `todos_for_ssh_key_ex... (#497334 - closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

This is all tested already. See !168528 (merged) for how to.

changed milestone to %17.6

added devopsfoundations feature flag featureaddition grouppersonal productivity sectioncore platform typefeature labels

assigned to @thutterer

added pipelinetier-1 label

added backend label

	1 Warning
	featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart. For more information, see: The Handbook page on merge request types. The definition of done documentation.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@syarynovskyi (UTC+2, 3.5 hours behind author)	@rzwambag (UTC+1, 4.5 hours behind author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@jagood Hi Jason Could please backend review this MR? Thanks!

requested review from @jagood

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for bafda91d

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
| Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
| Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
| Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
| Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
| Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 403    | 0      | 41      | 0     | 444   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for bafda91d

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 84     | 0      | 9       | 3     | 93    | ✅     |
| Create      | 139    | 0      | 21      | 0     | 160   | ✅     |
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Verify      | 50     | 0      | 15      | 0     | 65    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Secure      | 1      | 0      | 6       | 0     | 7     | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 435    | 0      | 120     | 3     | 555   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

requested review from @rzwambag

approved this merge request

resolved all threads

enabled automatic add to merge train when checks pass

added this merge request to the merge train at position 2

merged

mentioned in commit afb81c78

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

mentioned in issue #490325 (closed)

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label