Skip to content
Snippets Groups Projects

Project sidebar: Migrate color classes to design tokens

Merged Sascha Eggenberger requested to merge project-sidebar-color-class-migration into master
All threads resolved!

What does this MR do and why?

Project sidebar: Migrate color classes to design tokens

  • gl-text-gray-900 → gl-text-strong
  • gl-border-b-gray-500gl-border-b-subtle

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after
before_dark after_dark

How to set up and validate locally

  1. http://gdk.test:3000/flightjs/Flight

Related to #474922 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • added 1 commit

    • 2be5f8dc - Project sidebar: Migrate color classes to design tokens

    Compare with previous version

  • requested review from @vitallium

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 2be5f8dc

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Verify      | 44     | 0      | 2       | 0     | 46    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 403    | 0      | 41      | 0     | 444   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 2be5f8dc

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 84     | 0      | 9       | 3     | 93    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Verify      | 50     | 0      | 15      | 0     | 65    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Create      | 139    | 0      | 21      | 0     | 160   | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure      | 1      | 0      | 6       | 0     | 7     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 435    | 0      | 120     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Vitaly Slobodin approved this merge request

    approved this merge request

  • Vitaly Slobodin enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Vitaly Slobodin resolved all threads

    resolved all threads

  • Vitaly Slobodin removed this merge request from the merge train because the pipeline did not succeed. Learn more.

    removed this merge request from the merge train because the pipeline did not succeed. Learn more.

  • Vitaly Slobodin enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Sascha Eggenberger resolved all threads

    resolved all threads

  • Vitaly Slobodin removed this merge request from the merge train because the pipeline did not succeed. Learn more.

    removed this merge request from the merge train because the pipeline did not succeed. Learn more.

  • Vitaly Slobodin enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Hey there :wave:, could you please make sure this merge request gets merged?

    The merge request is set to auto-merge, but it is not currently mergeable (MR detailed_merge_status is discussions_not_resolved).

    This message was generated automatically. Improve it or delete it.

  • Sascha Eggenberger resolved all threads

    resolved all threads

  • mentioned in commit 48a9e9eb

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading