Fix non-overdue calendar icon color
What does this MR do and why?
In !167370 (merged) we modified the behavior of due dates to use icon variant, however 'default' was used in place of 'current', resulting in a slight mismatch from other nearby icons. This MR resets calendar color to current rather than default in order to match other nearby icons.
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After | Context |
---|---|---|
![]() |
![]() |
Issue list |
![]() |
![]() |
Issue board |
![]() |
![]() |
Epic list |
![]() |
![]() |
Epic child items |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Create an epic with a child item and assign a future due date to each
- View these items in the epic list, issue list, issue board, and within the epic's child items
Merge request reports
Activity
changed milestone to %17.6
added bugux groupproject management severity4 labels
assigned to @nickleonard
added typebug label
added pipelinetier-1 label
added devopsplan sectiondev labels
- A deleted user
added frontend label
1 Message This merge request includes changes to Vue files that have both CE and EE versions. Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/issues/list/components/issue_card_time_info.vue
ee/app/assets/javascripts/work_items/components/shared/work_item_link_child_metadata.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
Reviewer roulette
Category Reviewer Maintainer frontend @nradina
(UTC+1, 6 hours ahead of author)
@ekigbo
(UTC+11, 16 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Coung Ngo
@cngo Did not realize the default variant of GlIcon is actually
current
and not in factdefault
. As a result the calendar icon was being set with a fill color instead of inheriting one and appearing different from nearby icons (most visible when switched to dark mode). This MR fixes this.I tested using
subtle
but unless all icons are migrated to using GlIcon variants that would again result in a mismatch, so just changed tocurrent
to align with other instances.
requested review from @cngo
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8232644890 ee/spec/features/groups/work_items/work_item_spec.rb#L45
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 55.01 s < 50.13 s #8232572104 ee/spec/features/groups/work_items/work_item_spec.rb#L45
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 70.63 s < 50.13 s #8238075712 ee/spec/features/groups/work_items/work_item_spec.rb#L45
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when removing all children rolled up child dates 62.43 s < 50.13 s #8238075618 ee/spec/models/epic_spec.rb#L1039
Epic relative positioning there is a parent behaves like a class that supports relative positioning .move_nulls_to_end can move many nulls 45.51 s < 45.4 s #8238075726 ee/spec/features/groups/work_items/work_item_spec.rb#L45
Work item for signed in user for epic work items on the work item route behaves like work items rolled up dates when feature flag is enabled when using inheritable dates when updating child work item dates rolled up child dates 58.3 s < 50.13 s - A deleted user
added rspec:slow test detected label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 371412a9 and f5281a91
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.39 MB 4.39 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 371412a9. So we have used data from: 5e73a4d1.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f5281a91expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Govern | 75 | 0 | 4 | 1 | 79 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 397 | 0 | 46 | 1 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for f5281a91expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 14 | 94 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Create | 139 | 0 | 21 | 21 | 160 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Data Stores | 33 | 0 | 10 | 1 | 43 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Govern | 81 | 0 | 12 | 10 | 93 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 432 | 0 | 123 | 56 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 268eacad
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label