Skip to content
Snippets Groups Projects

Job log header: Re-add shadow

Merged Sascha Eggenberger requested to merge job-log-header-shadow-fix into master
All threads resolved!

What does this MR do and why?

Job log header: Re-add shadow

The shadow is needed as otherwise the content of the job log will bleed through (as the header has rounded corners) when scrolling. Also unifies the spacing for the meta information in the header.

This fixes a small regression introduced in Job page: Migrate to use design tokens (!170398 - merged) by removing the shadow.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before_shadow after_shadow
before after

How to set up and validate locally

  1. Go to a long job and scroll down

Related to #474922 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading