Job log header: Re-add shadow
What does this MR do and why?
Job log header: Re-add shadow
The shadow is needed as otherwise the content of the job log will bleed through (as the header has rounded corners) when scrolling. Also unifies the spacing for the meta information in the header.
This fixes a small regression introduced in Job page: Migrate to use design tokens (!170398 - merged) by removing the shadow.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Go to a long job and scroll down
Related to #474922 (closed)
Merge request reports
Activity
changed milestone to %17.6
assigned to @seggenberger
added UX UX Paper Cuts bugux frontend grouppipeline execution sectiondev typebug labels
added devopsfoundations label
added devopsverify label and removed devopsfoundations label
- Resolved by Phil Hughes
requested review from @sunjungp
added devopsfoundations groupux paper cuts sectioncore platform labels and removed devopsverify grouppipeline execution sectiondev labels
added pipelinetier-1 label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @nradina
(UTC+1, same timezone as author)
@iamphill
(UTC+0, 1 hour behind author)
UX @veethika
(UTC+0, 1 hour behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded grouppipeline execution label and removed groupux paper cuts label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c76cc6df and 9b79cf1a
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.4 MB 4.4 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for c76cc6df. So we have used data from: 2a6102ae.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Hey @iamphill can you maintainerize this small fix? TY!
requested review from @iamphill
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9b79cf1aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Govern | 76 | 0 | 3 | 1 | 79 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 398 | 0 | 44 | 1 | 442 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 9b79cf1aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 139 | 0 | 21 | 20 | 160 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Plan | 86 | 0 | 8 | 12 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 1 | 43 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Govern | 82 | 0 | 11 | 10 | 93 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 433 | 0 | 122 | 53 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit 186a29b0
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label