Remove the `/vue` URL suffix on the new todos dashboard
What does this MR do and why?
Remove the /vue
URL suffix on the new todos dashboard
The old and the new todos dashboards are now accessible at the same URL
(dashboard/todos
), but we render one or the other depending on the
todos_vue_application
feature flag's state.
The /vue
URL will redirect to the base URL until we remove the feature
flag.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Disable the
todos_vue_application
feature flag, then navigate to http://gdk.test:3000/dashboard/todos.- The legacy app should render.
- http://gdk.test:3000/dashboard/todos/vue should redirect to http://gdk.test:3000/dashboard/todos.
- Enable the
todos_vue_application
feature flag, then navigate to http://gdk.test:3000/dashboard/todos.- The new Vue app should render.
- http://gdk.test:3000/dashboard/todos/vue should redirect to http://gdk.test:3000/dashboard/todos.
Related to #501269 (closed)
Merge request reports
Activity
changed milestone to %17.6
assigned to @pgascouvaillancourt
added pipelinetier-1 label
removed pipelinetier-1 label
- A deleted user
added frontend label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @srushik
(UTC+5.5, 10.5 hours ahead of author)
@dbalexandre
(UTC+0, 5 hours ahead of author)
frontend @lwanko
(UTC+1, 6 hours ahead of author)
@svedova
(UTC+1, 6 hours ahead of author)
test for spec/features/*
@srushik
(UTC+5.5, 10.5 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- e9952394 - Remove the `/vue` URL suffix on the new todos dashboard
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1824668f and 86b0b896
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.46 MB 4.46 MB +2.08 KB 0.0 % mainChunk 3.36 MB 3.36 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.dashboard.todos.index 115.38 KB 714.42 KB +599.04 KB 519.2 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for 1824668f. So we have used data from: 17dfcf58.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 194 commits
-
e9952394...9c13431d - 193 commits from branch
master
- d34a334e - Remove the `/vue` URL suffix on the new todos dashboard
-
e9952394...9c13431d - 193 commits from branch
added 1 commit
- eb391090 - Remove the `/vue` URL suffix on the new todos dashboard
added 1 commit
- 20b15875 - Remove the `/vue` URL suffix on the new todos dashboard
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
removed review request for @nisong
requested review from @alipniagov
- Resolved by Aleksei Lipniagov
backend LGTM
assigned to @leipert
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 86b0b896expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 41 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 86b0b896expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed review request for @alipniagov
changed milestone to %17.7
added missed:17.6 label
aborted automatic add to merge train because the source branch was updated. Learn more.
added 4027 commits
-
20b15875...848d45e6 - 4026 commits from branch
master
- 8cb515fe - Remove the `/vue` URL suffix on the new todos dashboard
-
20b15875...848d45e6 - 4026 commits from branch
reset approvals from @alipniagov and @ohoral by pushing to the branch
added 1 commit
- 0b4ccc79 - Stub todos_vue_application in fixture generation
requested review from @alipniagov
requested review from @ohoral
mentioned in issue #483073 (closed)
- Resolved by Aleksei Lipniagov
@thutterer Could you have a look at
spec/features/dashboard/todos/todos_spec.rb
? Seems like you have been changing it lately and now it fails in this MR
assigned to @thutterer
aborted automatic add to merge train because the source branch was updated. Learn more.
reset approvals from @alipniagov and @ohoral by pushing to the branch