Update false positive alert to have uniform text size
What does this MR do and why?
Update false positive have uniform text size
Ensure doc link text in the false positive vulnerability alert has the same text size.
Issue: #481961 (closed)
Changelog: changed EE: true
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- Text change discussion: #481961 (comment 2182268569)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
To create a false positive alert for a vulnerability:
Copy from !93605 (merged)
vuln = Vulnerability.find(<id>) # replace `<id>` with the ID of the vulnerability you want to mark as a false positive.
flag = Vulnerabilities::Flag.new(finding: vuln.finding, origin: "", description: "This is a false positive")
flag.save
Related to #481961 (closed)
Merge request reports
Activity
changed milestone to %17.6
assigned to @sming-gitlab
added pipelinetier-1 label
removed pipelinetier-1 label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, maintenanceperformance, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @thomasrandolph
(UTC-6)
@pgascouvaillancourt
(UTC-4)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7b07c274 and 7e3f413e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.4 MB 4.4 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 7b07c274. So we have used data from: a0abb908.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger@beckalippert can you please give this a review?
requested review from @beckalippert
added pipeline:mr-approved label
added pipelinetier-2 label
- Resolved by David Pisek
@dpisek can you please review this when you have time? -- since it's a tiny change, a maintainer review should be enough here
requested review from @dpisek
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 7e3f413eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Govern | 75 | 0 | 4 | 1 | 79 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 397 | 0 | 46 | 1 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 7e3f413eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 81 | 0 | 12 | 10 | 93 | ✅ | | Create | 139 | 0 | 21 | 21 | 160 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Plan | 86 | 0 | 8 | 14 | 94 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Data Stores | 33 | 0 | 10 | 1 | 43 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 432 | 0 | 123 | 56 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 2febd87f
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label