Improve UI copy on the free and free trial registration screen
What does this MR do and why?
Resolves #499618 (closed), updates the email opt in copy. The updated version is proposed by @sselhorn
: #499618 (comment 2164961078), also has legal approval: #499618 (comment 2169935558)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After | |
---|---|---|
Regular registration | ![]() |
![]() |
Trial registration | ![]() |
![]() |
Merge request reports
Activity
changed milestone to %17.6
assigned to @rliu-gl
added docs-only label
added 1 commit
- 40b8e076 - Improve email opt in copy on registration pages
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @tle_gitlab
(UTC+10, 14 hours ahead of author)
@brytannia
(UTC+1, 5 hours ahead of author)
frontend @cwoolley-gitlab
(UTC-7, 3 hours behind author)
@apennells
(UTC-4, same timezone as author)
test for spec/features/*
@tle_gitlab
(UTC+10, 14 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved docs-only label
removed docs-only label
added docs-only label
removed docs-only label
added 188 commits
-
40b8e076...b3779f07 - 187 commits from branch
master
- af00a873 - Improve email opt in copy on registration pages
-
40b8e076...b3779f07 - 187 commits from branch
- Resolved by Alex Pennells
@apennells hi, I think this change is simple enough, we only need one maintainer review, can you help with this?
requested review from @apennells
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1b168145expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 75 | 0 | 4 | 1 | 79 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 397 | 0 | 46 | 1 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 1b168145expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Plan | 86 | 0 | 8 | 12 | 94 | ✅ | | Create | 139 | 0 | 21 | 20 | 160 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Govern | 81 | 0 | 12 | 10 | 93 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Data Stores | 33 | 0 | 10 | 1 | 43 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 432 | 0 | 123 | 53 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Alex Pennells
@rliu-gl Looks like there's a feature test that will need to be updated as well: https://gitlab.com/gitlab-org/gitlab/-/blob/fdcb5f80908339c810f4b1e1cf2439f3d72ff726/ee/spec/features/registrations/email_opt_in_registration_spec.rb#L76
aborted automatic add to merge train because the source branch was updated. Learn more.
added 95 commits
-
af00a873...acf605d5 - 94 commits from branch
master
- 58766169 - Improve email opt in copy on registration pages
-
af00a873...acf605d5 - 94 commits from branch
reset approvals from @apennells by pushing to the branch
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
- Resolved by Alex Pennells
@apennells unfortunately there's an unrelated flaky test failing the pipeline, it was retried a couple of times. I checked that it was quarantined in master, so rebasing to fix the pipeline.
aborted automatic add to merge train because the source branch was updated. Learn more.
added 238 commits
-
58766169...801b5733 - 237 commits from branch
master
- 5866a3da - Improve email opt in copy on registration pages
-
58766169...801b5733 - 237 commits from branch
aborted automatic add to merge train because the source branch was updated. Learn more.
added 41 commits
-
5866a3da...a644dae4 - 40 commits from branch
master
- 1b168145 - Improve email opt in copy on registration pages
-
5866a3da...a644dae4 - 40 commits from branch
started a merge train
mentioned in commit 723a7458
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label