Add Telemetry to new Todo Vue App
What does this MR do and why?
See #464083 (closed)
Instrument todo state changes in dodo List
Marking single or all todos as done / pending are now instrumented properly.
Instrument clicking on todo links
We send the fact that someone clicks a todo in the todo list and the type of todo clicked.
Instrument sorting changes in todo list
Every time the direction or kind of sorting changes, we emit an event
Instrument tab changes in the todo list
Because this is what we want to know. Yay.
Instrument the selection of filters in todo list app
This one is a little non-trivial. We decided that the filters should be sent upon selection not upon submission. We could consider changing this in a follow-up, because it would make the code much easier to parse. Right now we handle the following edge cases:
- If you remove a filter, no new event is sent
- If you edit a filter, no new event is sent
- If you select multiple filters, multiple events are sent
- If you select filters, events are sent, reset and then select again, events are sent
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screen_Recording_2024-10-25_at_16.39.52
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @leipert
changed milestone to %17.6
removed missed-deliverable label
removed missed:17.5 label
removed missed:17.4 label
added workflowin review label and removed workflowready for development label
added docs-only label
added 643 commits
-
61a5ca93...47d1a31d - 638 commits from branch
master
- b18f9043 - Instrument todo state changes in dodo List
- daeb94a6 - Instrument clicking on todo links
- 1467fbfe - Instrument sorting changes in todo list
- c3c92c43 - Instrument tab changes in the todo list
- e583b88b - Instrument the selection of filters in todo list app
Toggle commit list-
61a5ca93...47d1a31d - 638 commits from branch
@pgascouvaillancourt Could you review? Thank you
requested review from @pgascouvaillancourt
removed docs-only label
- A deleted user
1 Warning For the following files, a review from the Data team and Analytics Instrumentation team is recommended
Please check the analytics instrumentation Service Ping guide or the Snowplow guide.For MR review guidelines, see the Internal Analytics review guidelines.
config/events/click_todo_item_action.yml
config/events/filter_todo_list.yml
config/events/follow_todo_link.yml
config/events/sort_todo_list.yml
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer analytics instrumentation @nbelokolodov
(UTC+13, 11 hours ahead of author)
Maintainer review is optional for analytics instrumentation frontend @thomasrandolph
(UTC-6, 8 hours behind author)
@tbulva
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 37088e9f and e583b88b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.39 MB 4.39 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 37088e9f. So we have used data from: fd4a54f4.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
- Resolved by Paul Gascou-Vaillancourt
LGTM @leipert!
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e583b88bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 397 | 0 | 44 | 0 | 441 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for e583b88bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Plan | 86 | 0 | 8 | 12 | 94 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Govern | 79 | 0 | 11 | 8 | 90 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Create | 139 | 0 | 21 | 17 | 160 | ✅ | | Secure | 1 | 0 | 5 | 0 | 6 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 430 | 0 | 121 | 47 | 551 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit f0155795
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label