Skip to content
Snippets Groups Projects

Add Telemetry to new Todo Vue App

Merged Lukas Eipert requested to merge leipert-add-telemetry into master
All threads resolved!

What does this MR do and why?

See #464083 (closed)

Instrument todo state changes in dodo List

Marking single or all todos as done / pending are now instrumented properly.

Instrument clicking on todo links

We send the fact that someone clicks a todo in the todo list and the type of todo clicked.

Instrument sorting changes in todo list

Every time the direction or kind of sorting changes, we emit an event

Instrument tab changes in the todo list

Because this is what we want to know. Yay.

Instrument the selection of filters in todo list app

This one is a little non-trivial. We decided that the filters should be sent upon selection not upon submission. We could consider changing this in a follow-up, because it would make the code much easier to parse. Right now we handle the following edge cases:

  1. If you remove a filter, no new event is sent
  2. If you edit a filter, no new event is sent
  3. If you select multiple filters, multiple events are sent
  4. If you select filters, events are sent, reset and then select again, events are sent

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screen_Recording_2024-10-25_at_16.39.52

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Lukas Eipert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • resolved all threads

  • Paul Gascou-Vaillancourt enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for e583b88b

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Package     | 17     | 0      | 18      | 0     | 35    | ✅     |
    | Create      | 129    | 0      | 19      | 0     | 148   | ✅     |
    | Verify      | 45     | 0      | 2       | 0     | 47    | ✅     |
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 397    | 0      | 44      | 0     | 441   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for e583b88b

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Plan        | 86     | 0      | 8       | 12    | 94    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Govern      | 79     | 0      | 11      | 8     | 90    | ✅     |
    | Verify      | 50     | 0      | 15      | 10    | 65    | ✅     |
    | Create      | 139    | 0      | 21      | 17    | 160   | ✅     |
    | Secure      | 1      | 0      | 5       | 0     | 6     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 430    | 0      | 121     | 47    | 551   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • mentioned in commit f0155795

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading