Skip to content
Snippets Groups Projects

Added ability to push multi result count to sidebar

Merged Tomas Bulva requested to merge tbulva-count-results-in-multi-result into master
All threads resolved!

What does this MR do and why?

Added ability to push multi-result count to sidebar

Currently all counts for the results in the left sidebar are collected using separate api that allows us to get Elastic Search results. The new multi-result page is using graphQL and Zoekt. This MR is fixing the simplest scenario for rendering results count in the sidebar.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-10-25_at_16.08.48 Screenshot_2024-10-25_at_16.05.21

How to set up and validate locally

  1. Enable the forks filter FF
    echo 'Feature.enable(:zoekt_multimatch_frontend)' | rails c
  2. Make sure advanced search is installed and enabled
  3. Make sure you enable zoekt.
  4. Visit search page http://gdk.test:3000/search
  5. Search code using namespace where zoekt is enabled
  6. Status bar results number and sidebar results number should are same.

related to #499691 (closed)

Edited by Tomas Bulva

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested changes

  • Tomas Bulva added 1 commit

    added 1 commit

    • f4e9503c - Removed action method. Calling mutation method directly.

    Compare with previous version

  • Tomas Bulva requested review from @slashmanov

    requested review from @slashmanov

  • Tomas Bulva added 1 commit

    added 1 commit

    • 14e08714 - Removed action method. Calling mutation method directly.

    Compare with previous version

  • Stanislav Lashmanov approved this merge request

    approved this merge request

  • Stanislav Lashmanov resolved all threads

    resolved all threads

  • Stanislav Lashmanov enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Stanislav Lashmanov added this merge request to the merge train at position 6

    added this merge request to the merge train at position 6

  • mentioned in commit 5f85970c

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading