Added ability to push multi result count to sidebar
What does this MR do and why?
Added ability to push multi-result count to sidebar
Currently all counts for the results in the left sidebar are collected using separate api that allows us to get Elastic Search results. The new multi-result page is using graphQL and Zoekt. This MR is fixing the simplest scenario for rendering results count in the sidebar.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable the forks filter FF
echo 'Feature.enable(:zoekt_multimatch_frontend)' | rails c
- Make sure advanced search is installed and enabled
- Make sure you enable zoekt.
- Visit search page
http://gdk.test:3000/search
- Search code using namespace where zoekt is enabled
- Status bar results number and sidebar results number should are same.
related to #499691 (closed)
Merge request reports
Activity
assigned to @tbulva
added pipelinetier-1 label
1 Warning 14e08714: The commit subject must not end with a period. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer frontend @eduardobonet
(UTC+1, same timezone as author)
@slashmanov
(UTC+4, 3 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8bffb092 and 14e08714
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.39 MB 4.39 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 11 commits
-
abb149e2...d1dc10bd - 10 commits from branch
master
- 269671cf - Added ability to push multi-result count to sidebar
-
abb149e2...d1dc10bd - 10 commits from branch
- Resolved by Stanislav Lashmanov
requested review from @dzubova
removed review request for @dzubova
requested review from @dzubova
changed milestone to %17.6
added bugfunctional typebug labels and removed typefeature label
removed featureenhancement label
requested review from @slashmanov and removed review request for @dzubova
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 14e08714expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Govern | 76 | 0 | 3 | 1 | 79 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 398 | 0 | 44 | 1 | 442 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 14e08714expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Create | 139 | 0 | 21 | 18 | 160 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 86 | 0 | 8 | 12 | 94 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Data Stores | 33 | 0 | 10 | 1 | 43 | ✅ | | Govern | 82 | 0 | 11 | 10 | 93 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 1 | 0 | 5 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 433 | 0 | 121 | 51 | 554 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Stanislav Lashmanov
added 1 commit
- f4e9503c - Removed action method. Calling mutation method directly.
requested review from @slashmanov
added 1 commit
- 14e08714 - Removed action method. Calling mutation method directly.
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
added this merge request to the merge train at position 6
mentioned in commit 5f85970c
added backportskip label
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added devopsfoundations label and removed devopsdata stores label