Revert "Merge branch 'mk/add-geo-developer-console' into 'master'"

changed milestone to %17.5

added Pick into auto-deploy master:broken pipelineexpedited priority1 severity1 labels

assigned to @jennli

added Quality label

requested review from @mkozono

mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8904 (closed)

approved this merge request

added backend label

	2 Warnings
	In a revert merge request? Use the revert merge request template to add labels that skip changelog checks. Reverting something in the current milestone? A changelog isn't required. Skip changelog checks by adding `~"regression:*"` label, then re-run the danger job (there is a link at the bottom of this comment).
	This merge request is quite big (1408 lines changed), please consider splitting it into multiple merge requests.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@dbiryukov` (UTC+2, 9 hours ahead of author)	`@pedropombeiro` (UTC+2, 9 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

approved this merge request

I thought it was a race condition in the factory, but maybe it is a race condition possible in the codebase itself. The MR merged after two successful pipelines in a row.

!166554 (comment 2151351329)

The failure seems to be in the usage of the verification_failed trait. I wonder if it's a race when using it in create_list, because the same spec passed in the pipeline before I last pinged you. Anyway I fixed the test by avoiding the trait.

Proper labels assigned to this merge request. Please ignore me.

@jennli - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

added typebug label

resolved all threads

added regression:17.5 label

marked the checklist item I am reverting something in the current milestone. No changelog is needed, and I've added a ~"regression:*" label. as completed

marked the checklist item Create an issue to reinstate the merge request and assign it to the author of the reverted merge request. as completed

marked the checklist item If the revert is to resolve a broken 'master' incident, please read through the Responsibilities of the Broken master resolution DRI. as completed

marked the checklist item If the revert involves a database migration, please read through Deleting existing migrations. as completed

marked the checklist item Add the appropriate labels before the MR is created. We can skip CI/CD jobs only if the labels are added before the CI/CD pipeline is created. as completed

started a merge train

merged

mentioned in commit 1c76230e

mentioned in merge request !166554 (merged)

mentioned in issue #498746 (closed)

Successfully picked into 17-5-auto-deploy-2024101020.

This merge request will receive additional notifications as it's deployed. You can also use the following chatops command to check its status: /chatops run auto_deploy status https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168860