Skip to content
Snippets Groups Projects

Reset Group Callout For All Seats Used Banner When Deleting a Member

Merged Jason Goodman requested to merge reset-seat-callout-worker-fix into master
All threads resolved!

What does this MR do and why?

Reset group callout for all seats used banner when deleting a member

Pass the group id rather than the group object to the worker.

Related issue: https://gitlab.com/gitlab-org/gitlab/-/issues/441795

See also discussion here: https://gitlab.com/gitlab-org/gitlab/-/issues/441795#note_2144930388

Original MR that introduced the callout reset on member removal: !152171 (merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots

This is the callout for the banner below:

Screenshot_2024-10-07_at_3.20.06_PM

Edited by Jason Goodman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jason Goodman
  • Jason Goodman
  • Jason Goodman requested review from @agulina

    requested review from @agulina

  • Jason Goodman changed the description

    changed the description

  • Hey @vshushlin, :wave:

    would you have time to look at this merge request, please? Thanks!

  • Angelo Gulina requested review from @vshushlin

    requested review from @vshushlin

  • Angelo Gulina approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 0c86cba0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Verify      | 45     | 0      | 2       | 0     | 47    | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Create      | 128    | 0      | 18      | 0     | 146   | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Govern      | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 401    | 0      | 33      | 0     | 434   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :x: test report for 0c86cba0

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Manage         | 23     | 2      | 10      | 6     | 35    | ❌     |
    | Create         | 422    | 2      | 60      | 1     | 484   | ❌     |
    | Analytics      | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Fulfillment    | 4      | 0      | 7       | 0     | 11    | ✅     |
    | Govern         | 26     | 0      | 1       | 0     | 27    | ✅     |
    | Package        | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Systems        | 6      | 0      | 1       | 0     | 7     | ✅     |
    | Monitor        | 4      | 0      | 1       | 0     | 5     | ✅     |
    | Data Stores    | 13     | 0      | 1       | 0     | 14    | ✅     |
    | Secure         | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Configure      | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Plan           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Ai-powered     | 0      | 1      | 0       | 0     | 1     | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 511    | 5      | 82      | 7     | 598   | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+
  • Vladimir Shushlin resolved all threads

    resolved all threads

  • Vladimir Shushlin approved this merge request

    approved this merge request

  • Thanks, @jagood ! :green_heart:

    LGTM :rocket:

  • Vladimir Shushlin added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • Vladimir Shushlin removed this merge request from the merge train because the pipeline did not succeed. Learn more.

    removed this merge request from the merge train because the pipeline did not succeed. Learn more.

  • Vladimir Shushlin enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • mentioned in commit 2b0eb099

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading