Fix alignment of legacy system notes
What does this MR do and why?
Fix alignment of system notes on legacy items (commits and snippets)
What does this MR not do?
- System notes should use the
dot
instead of any icons on the activity timeline
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Mention commit in an issue/MR etc
Links
Merge request reports
Activity
changed milestone to %17.4
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
added pipelinetier-1 label
- A deleted user
added backend label
2 Warnings The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer backend @sam.figueroa
(UTC+0, same timezone as author)
@drew
(UTC+0, same timezone as author)
frontend @aalakkad
(UTC+3, 3 hours ahead of author)
@tristan.read
(UTC+12, 12 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@pgascouvaillancourt Could you please review?
requested review from @pgascouvaillancourt
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 57f7c973 and 34f5f062
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.35 MB 4.35 MB - 0.0 % mainChunk 3.29 MB 3.29 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
LGTM, thanks @annabeldunstone!
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 34f5f062expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 46 | 0 | 2 | 0 | 48 | ✅ | | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Plan | 74 | 0 | 1 | 0 | 75 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 395 | 0 | 33 | 0 | 428 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 1ffaa3c9
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8441 (closed)
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#8442 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
11 11 12 12 .system-note { 13 13 .note-text { 14 color: $gl-text-color !important; 14 color: var(--gl-text-color-default); @annabeldunstone, I believe the change in the color font has caused this issue when in dark mode:
See for example this highlighted note (in dark mode): !165393 (comment 2111991048)
It seems that the !165568 (merged) caused the issue.
mentioned in merge request !165568 (merged)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label