Skip to content

Remove @pipeline from `vulnerabilities_controller`

Michael Becker requested to merge task-epic-11241-remove-unused-variable into master

What does this MR do and why?

As part of the epic to delete the vulnerability_occurrence_pipelines table I noticed that this usage of finding.first_finding_pipeline appears to

  1. be the only use
  2. be used to set a variable that is the subsequently unused

Details are in this thread

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screencast_from_08-30-2024_07_48_02_PM Screencast_from_08-30-2024_07_43_38_PM
description Prior to this change, when I look at a vulnerability detail page, I see no pipeline information.

I then load the finding by id in the rails console and call finding.first_finding_pipeline to verify the pipeline and finding are associated.
After this change, I run through the same process. The detail page looks the same, and when I try calling first_finding_pipeline in the console I get a NoMethodError

related to: gitlab-org#11241

Changelog: removed
EE: true

Edited by Michael Becker

Merge request reports

Loading