Exclude PrometheusAlerts in count of issues with alerts in service ping
All threads resolved!
All threads resolved!
Compare changes
@@ -127,8 +127,7 @@ def object_with_schema?(key_path)
Changes: This MR cleans up a portion of dead code related to the removal of devopsmonitor Category:Metrics features.
Scope: Any service ping metrics related to PrometheusAlert
records. We're going to be dropping the table referenced from Instrumentations::IssuesWithPrometheusAlertEvents
, which allows us to simplify the implementation of counts.issues_created_from_alerts
. After this merges, the reported value may initially drop, but that's expected and fine.
Context: The Metrics Dashboard (used for monitoring apps deploying using gitlab) was deprecated in 14.7 and removed from the product in 16.0. There are many more files to remove related to this cleanup, but this should be a self-contained chunk.
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
These features were disabled in %16.0 behind the :remove_monitor_metrics
feature flag, and have been partially deleted since then. So there's nothing really to test here. It's no longer possible to set up these features.