Skip to content

Advanced SAST GA - Disabled by default and when enabled, only on supported languages (only latest template)

Meir Benayoun requested to merge 474094-glas-disabled-by-default into master

What does this MR do and why?

The GitLab Advanced SAST is going GA.
For the upcoming version %17.3, it will remain opt-in and disabled by default.
When it is enabled, Semgrep analyzer will skip the languages already covered by GitLab Advanced SAST.

Following the decision to split the MR into 2 parts.
The current MR is updating only the latest SAST template.
A follow-up MR has been created for updating the stable SAST template.

This MR is doing the following:

  • Add CI variable GITLAB_ADVANCED_SAST_ENABLED
  • Add new languages covered by GitLab Advanced SAST: JavaScript, TypeScript and C#
  • Don't run Semgrep analyzer in case GitLab Advanced SAST analyzer already covers all the languages present in the repo
  • In case GitLab Advanced SAST analyzer scans only part of the files, Semgrep analyzer will run only on the other files
  • Update rspec tests
  • Update GitLab Advanced SAST documentation

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #474094.
https://gitlab.com/gitlab-org/gitlab/-/issues/474094+s

Edited by Meir Benayoun

Merge request reports