Change Sidekiq testing mode to `fake` instead of `inline`
All threads resolved!
All threads resolved!
This changes the Sidekiq mode from inline
to fake
in the test
environment.
This should hopefully make RSpec jobs run faster.
Documentation has been updated:
Sidekiq jobs are typically not run in specs, but this behaviour can be altered in each spec through the use of
perform_enqueued_jobs
blocks. Any spec that causes Sidekiq jobs to be pushed to Redis should use the:sidekiq_inline
trait, to ensure that they are removed once the spec completes.The
:sidekiq_might_not_need_inline
trait was added when Sidekiq inline mode was changed to fake mode to all the examples that needed Sidekiq to actually process jobs. Examples with this trait should be either fixed to not rely on Sidekiq processing jobs, or their:sidekiq_might_not_need_inline
trait should be updated to:sidekiq_inline
if the processing of background jobs is needed/expected.
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
@gitlab-com/gl-security/appsec
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/16098.