Change Sidekiq testing mode to `fake` instead of `inline`
-
Review changes -
-
Download -
Patches
-
Plain diff
What does this MR do?
This changes the Sidekiq mode from inline
to fake
in the test
environment.
This should hopefully make RSpec jobs run faster.
Documentation has been updated:
Sidekiq jobs are typically not run in specs, but this behaviour can be altered in each spec through the use of
perform_enqueued_jobs
blocks. Any spec that causes Sidekiq jobs to be pushed to Redis should use the:sidekiq_inline
trait, to ensure that they are removed once the spec completes.The
:sidekiq_might_not_need_inline
trait was added when Sidekiq inline mode was changed to fake mode to all the examples that needed Sidekiq to actually process jobs. Examples with this trait should be either fixed to not rely on Sidekiq processing jobs, or their:sidekiq_might_not_need_inline
trait should be updated to:sidekiq_inline
if the processing of background jobs is needed/expected.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
-
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/16098.
Merge request reports
- version 28df47210f
- version 27834feffe
- version 267ddb54bf
- version 2524e1c2b5
- version 24ecc04f10
- version 23c5aa8e1c
- version 2208542d52
- version 21923db881
- version 205b1d7c69
- version 193f8a937e
- version 18d6fdc31e
- version 17c81deac4
- version 164c39d0e7
- version 1596765347
- version 1414ec9af3
- version 1333e0a23a
- version 1281e6e4c4
- version 11f66efe59
- version 10d45fb118
- version 91f757ba3
- version 833845387
- version 7ae939de0
- version 660de6ac3
- version 52beabf69
- version 4f52943fd
- version 33c9ce493
- version 28a753852
- version 1821a4971
- master (base)
- latest version6309f06b4 commits,
- version 28df47210f4 commits,
- version 27834feffe4 commits,
- version 267ddb54bf4 commits,
- version 2524e1c2b54 commits,
- version 24ecc04f104 commits,
- version 23c5aa8e1c4 commits,
- version 2208542d524 commits,
- version 21923db8814 commits,
- version 205b1d7c694 commits,
- version 193f8a937e4 commits,
- version 18d6fdc31e4 commits,
- version 17c81deac44 commits,
- version 164c39d0e74 commits,
- version 15967653474 commits,
- version 1414ec9af34 commits,
- version 1333e0a23a4 commits,
- version 1281e6e4c44 commits,
- version 11f66efe594 commits,
- version 10d45fb1183 commits,
- version 91f757ba33 commits,
- version 8338453873 commits,
- version 7ae939de03 commits,
- version 660de6ac33 commits,
- version 52beabf694 commits,
- version 4f52943fd3 commits,
- version 33c9ce4933 commits,
- version 28a7538523 commits,
- version 1821a49713 commits,
- Side-by-side
- Inline
There are no changes yet
No changes between version 4 and version 4