Add MergeRequestReader to chat

What does this MR do and why?

Addresses one popular context the chat currently does not support: https://gitlab.com/gitlab-org/ai-powered/duo-chat/discussions/-/issues/3+

Specifically this MR addresses Support Merge Requests as context for Duo Chat ... (#464587 - closed) • Lesley Razzaghian • 17.5 • Needs attention

Evaluation results

Here are the evaluation results from a collective LLM judge on the master branch

Here are the results on this branch

Here are the stats (averages)

Master branch

Correctness: 3.65

Readability: 3.75

Comprehensiveness: 3.43

This branch

Correctness: 3.71

Readability: 3.75

Comprehensiveness: 3.53

The improved results in the existing evaluation are likely not statistically significant, but at least it proves these changes do not degrade existing questions.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

1. In rails console enable the experiment fully

   Feature.enable(:ai_merge_request_reader_for_chat)

2. Visit merge request and ask question, for example: summarize this Merge request

What needs to be done

Task	Status	Notes
Run CEF locally on this branch vs master to ensure no degradation		See above in 'Evaluation results'
Create basic dataset for MR eval		Here
Change Chat REST API to accept MR requests
Add seed data for merge requests to be able to test locally in CEF		I believe this can be a followup
Make this work with 'v2_chat_agent_integration' feature flag on		This MR just needs to be merged after this one has been rolled out
Ask model validation team to add this dataset to daily runs, merge this MR and monitor eval results		Asked them to add it discussion

ee/spec/lib/gitlab/llm/chain/tools/merge_request_reader/prompts/anthropic_spec.rb

@@ -7,31 +7,30 @@
     let(:options) { { input: 'test input', suggestions: 'test suggestions' } }
 
     describe '.prompt' do
-        it 'returns prompt' do
-          prompt = described_class.prompt(options)[:prompt]
-    
-          expect(prompt.length).to eq(3)
-    
-          binding.pry
-          expect(prompt[0][:role]).to eq(:system)
-          expect(prompt[0][:content]).to eq(system_prompt)
-    
-          expect(prompt[1][:role]).to eq(:user)
-          expect(prompt[1][:content]).to eq(options[:input])
-    
-          expect(prompt[2][:role]).to eq(:assistant)
-          expect(prompt[2][:content]).to include(options[:suggestions], "\"ResourceIdentifierType\": \"")
-        end
-    
-        it "calls with haiku model" do
-          model = described_class.prompt(options)[:options][:model]
-    
-          expect(model).to eq(::Gitlab::Llm::AiGateway::Client::CLAUDE_3_HAIKU)
-        end
+      it 'returns prompt' do
+        prompt = described_class.prompt(options)[:prompt]
+
+        expect(prompt.length).to eq(3)
+
+        expect(prompt[0][:role]).to eq(:system)
+        expect(prompt[0][:content]).to eq(system_prompt)
+
+        expect(prompt[1][:role]).to eq(:user)
+        expect(prompt[1][:content]).to eq(options[:input])
+
+        expect(prompt[2][:role]).to eq(:assistant)
+        expect(prompt[2][:content]).to include(options[:suggestions], "\"ResourceIdentifierType\": \"")
       end
-    
-      def system_prompt
-        Gitlab::Llm::Chain::Tools::MergeRequestReader::Executor::SYSTEM_PROMPT[1]
+
+      it "calls with haiku model" do
+        model = described_class.prompt(options)[:options][:model]
+
+        expect(model).to eq(::Gitlab::Llm::AiGateway::Client::CLAUDE_3_HAIKU)
       end
+    end
+
+    def system_prompt
+      Gitlab::Llm::Chain::Tools::MergeRequestReader::Executor::SYSTEM_PROMPT[1]
+    end
   end
 end