Skip to content
Snippets Groups Projects

Add `admin_runners` custom role permission

Merged mo khan requested to merge mokhax/442851/admin_runners into master
All threads resolved!
Compare and Show latest version
1 file
+ 24
0
Compare changes
  • Side-by-side
  • Inline
@@ -59,6 +59,30 @@
let_it_be(:runner) { create(:ci_runner, :project, projects: [project]) }
it { expect_allowed :read_runner }
it 'avoids N+1 queries' do
runner = create(:ci_runner, :project, :without_projects)
control = ActiveRecord::QueryRecorder.new do
described_class.new(user, runner).allowed?(:read_runner)
end
create_list(:project, 3).each do |project|
project.add_member(user, :guest)
runner.runner_projects.create!(project: project)
end
expect do
described_class.new(user, runner).allowed?(:read_runner)
end.not_to exceed_query_limit(control)
end
context 'with `custom_ability_admin_runners` disabled' do
before do
stub_feature_flags(custom_ability_admin_runners: false)
end
it { expect_disallowed :read_runner }
end
end
end
end
Loading