Update ListboxHelper to adhere to Pajamas style

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

Fixes: #417800 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

See !151151 (comment 1911124165).

How to set up and validate locally

1. Visit some of the places this helper is used:
   • project forks page http://gdk.test:3000/gitlab-org/gitlab-test/-/forks
   • project starrers page http://gdk.test:3000/gitlab-org/gitlab-test/-/starrers
2. Ensure the dropdown looks correct. Ideally, load the page with JavaScript disabled, since the markup this changes is completely replaced by Vue components once JS is executed.
3. Bonus points: compare DOM structure with a real listbox (just the button and parent element, not the menu).

app/helpers/listbox_helper.rb

@@ -2,7 +2,7 @@
 
 module ListboxHelper
   DROPDOWN_CONTAINER_CLASSES = %w[dropdown b-dropdown gl-dropdown js-redirect-listbox].freeze
-  DROPDOWN_BUTTON_CLASSES = %w[btn dropdown-toggle btn-default btn-md gl-button gl-dropdown-toggle].freeze
+  DROPDOWN_BUTTON_CLASSES = %w[btn dropdown-toggle btn-default btn-md gl-dropdown-toggle].freeze
   DROPDOWN_INNER_CLASS = 'gl-dropdown-button-text'
   DROPDOWN_ICON_CLASS = 'gl-button-icon dropdown-chevron gl-icon'
 
@@ -46,7 +46,8 @@ def gl_redirect_listbox_tag(items, selected, html_options = {})
       selected = selected_option[:value]
     end
 
-    button = button_tag(type: :button, class: DROPDOWN_BUTTON_CLASSES) do
+    button = render Pajamas::ButtonComponent.new(variant: :default,
+      button_options: { class: DROPDOWN_BUTTON_CLASSES }) do
       content_tag(:span, selected_option[:text], class: DROPDOWN_INNER_CLASS) +
         sprite_icon('chevron-down', css_class: DROPDOWN_ICON_CLASS)
     end