Fix GraphQL pipeline findings pagination

What does this MR do and why?

Fix GraphQL pagination on the pipeline.securityReportFindings resolver.

This requires some fairly in depth reworking explained below:

Rework of SecurityFindingsFinder#limit calculation

This finder was implemented for a REST endpoint where pagination is implemented with page and per_page parameters. It uses offset pagination currently (conversion to keyset is planned). Because of this the pagination boundaries (OFFSET) always fall on equal divisions of per_page size.

                     REST pagination

      page:1 per_page:10           page:2 per_page:10
|----------------------------|-----------------------------|----
 1  2  3  4  5  6  7  8  9 10 11 12 13 14 15 16 17 18 19 20 21 ..

The GraphQL cursor based pagination can use arbitrary offsets using first or last arguments to specify page size and before or after to determine the offset

                     GQL pagination

                         first:12 after:5
               |----------------------------------|
 1  2  3  4  5  6  7  8  9 10 11 12 13 14 15 16 17 18 19 20 21 ..

The Security::FindingsFinder has undergone extensive customization over time to make it perform acceptably with large data sets. To facilitate this the finder needs to know some information about the current pagination position. Previously it was using the page and per_page parameters from the REST endpoint to determine this, but with this change it has needed to be modified.

Getting pagination information from the GQL resolver

The default GraphQL connection implementation removes the pagination arguments before calling resolve, so the pagination params are not available by default. Using connection_extension: ::Gitlab::Graphql::Extensions::ExternallyPaginatedArrayExtension works around this.

Once these arguments are available they require some manipulation to read. The first and last arguments are plain integers, but before and after are base64 encoded strings. Usually they contain encoded JSON with the keyset pagination parameters, but when using offset_paginate before and after contain the base64 encoded first and last id of the returned record set.

Steps to reproduce

Ensure you have EE features and pipeline runners available on your GDK.

• git switch master
• Clone https://gitlab.com/gl-demo-ultimate-myacksmith/482983-test-group/graphql-vulnerability-findings-test into your GDK
• In rails console set the feature flag to use GraphQL instead of REST on the pipeline security tab Feature.enable(:pipeline_security_dashboard_graphql)
• Once the project's pipeline has completed, visit 'Pipeline -> Security'
• The 'Scan details' section should show a count of 164 vulnerabilities'
• Paginate through the vulnerability list. The full list of findings is not shown.
• git switch 441306-security-report-finding-pagination
• You should now be able to paginate through all of the findings.

Related to #441306 (closed)

ee/app/finders/security/findings_finder.rb

@@ -11,8 +11,7 @@
 #     confidence:  Array<String>
 #     report_type: Array<String>
 #     scope:       String
-#     page:        Int
-#     per_page:    Int
+#     limit:       Int
 
 module Security
   class FindingsFinder
@@ -23,8 +22,7 @@ class FindingsFinder
         :next_page, :prev_page, :page, :empty?, :without_count, to: :relation
     end
 
-    DEFAULT_PAGE = 1
-    DEFAULT_PER_PAGE = 20
+    DEFAULT_LIMIT = 20
 
     def initialize(pipeline, params: {})
       @pipeline = pipeline
@@ -32,7 +30,7 @@ def initialize(pipeline, params: {})
     end
 
     def execute
-      return ResultSet.new(Security::Finding.none.page(DEFAULT_PAGE), []) unless has_security_findings?
+      return ResultSet.new(Security::Finding.none, []) unless has_security_findings?
 
       ResultSet.new(security_findings, findings)
     end
@@ -100,8 +98,6 @@ def load_security_findings
               .deduplicated
               .ordered(params[:sort])
               .merge(::Security::Scan.latest_successful)
-              .page(page)
-              .per(per_page)
               .then { |relation| by_uuid(relation) }
               .then { |relation| by_confidence_levels(relation) }
               .then { |relation| by_report_types(relation) }
@@ -149,7 +145,7 @@ def load_security_findings_lateral
         .then { |relation| by_scanner_external_ids(relation) }
         .then { |relation| by_state(relation) }
         .then { |relation| by_include_dismissed(relation) }
-        .limit((per_page * page) + 1)
+        .limit(limit + 1)
 
       from_sql = <<~SQL.squish
           "security_scans",
@@ -169,16 +165,10 @@ def load_security_findings_lateral
         .merge(::Security::Scan.latest_successful)
         .ordered(params[:sort])
         .then { |relation| by_report_types(relation) }
-        .page(page)
-        .per(per_page)
     end
 
-    def per_page
-      @per_page ||= params[:per_page] || DEFAULT_PER_PAGE
-    end
-
-    def page
-      @page ||= params[:page] || DEFAULT_PAGE
+    def limit
+      @limit ||= params[:limit] || DEFAULT_LIMIT
     end
 
     def include_dismissed?