From 8238fd67527d7b8e35849d325b291247ab4d8f73 Mon Sep 17 00:00:00 2001 From: Libor Vanc <lvanc@gitlab.com> Date: Tue, 23 Jan 2024 10:27:27 -1000 Subject: [PATCH 1/4] Adds top margin on 2nd line --- .../merge_request_analytics/components/throughput_table.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue index 96fbacfe5da7e2..590cdac1681c90 100644 --- a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue +++ b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue @@ -288,7 +288,7 @@ export default { class="gl-font-weight-bold gl-text-gray-900" >{{ item.title }}</gl-link > - <ul class="horizontal-list gl-mb-0"> + <ul class="horizontal-list gl-mt-2"> <li class="gl-mr-3">{{ formatMergeRequestId(item.iid) }}</li> <li v-if="hasPipelineNodes(item) && item.pipelines.nodes.length" class="gl-mr-3"> <gl-icon -- GitLab From 9ccba1e9f745c4f1bce4b7452f38f732b0195cd0 Mon Sep 17 00:00:00 2001 From: Libor Vanc <lvanc@gitlab.com> Date: Wed, 24 Jan 2024 09:10:09 -1000 Subject: [PATCH 2/4] Added back margin bottom class --- .../merge_request_analytics/components/throughput_table.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue index 590cdac1681c90..28b7e0848cc38f 100644 --- a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue +++ b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue @@ -288,7 +288,7 @@ export default { class="gl-font-weight-bold gl-text-gray-900" >{{ item.title }}</gl-link > - <ul class="horizontal-list gl-mt-2"> + <ul class="horizontal-list gl-mt-2 gl-mb-0"> <li class="gl-mr-3">{{ formatMergeRequestId(item.iid) }}</li> <li v-if="hasPipelineNodes(item) && item.pipelines.nodes.length" class="gl-mr-3"> <gl-icon -- GitLab From 73f58cbe8ed4ace9331a9bd6dd5b20fe30166250 Mon Sep 17 00:00:00 2001 From: Libor Vanc <lvanc@gitlab.com> Date: Tue, 23 Jan 2024 10:27:27 -1000 Subject: [PATCH 3/4] fixed: Added spacing between multiple lines of text in the Merge request analytics table --- .../merge_request_analytics/components/throughput_table.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue index 96fbacfe5da7e2..590cdac1681c90 100644 --- a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue +++ b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue @@ -288,7 +288,7 @@ export default { class="gl-font-weight-bold gl-text-gray-900" >{{ item.title }}</gl-link > - <ul class="horizontal-list gl-mb-0"> + <ul class="horizontal-list gl-mt-2"> <li class="gl-mr-3">{{ formatMergeRequestId(item.iid) }}</li> <li v-if="hasPipelineNodes(item) && item.pipelines.nodes.length" class="gl-mr-3"> <gl-icon -- GitLab From 15427b0923ca38a4b70ad62bacf1684ca72d64e3 Mon Sep 17 00:00:00 2001 From: Libor Vanc <lvanc@gitlab.com> Date: Wed, 24 Jan 2024 09:10:09 -1000 Subject: [PATCH 4/4] Added back margin bottom class --- .../merge_request_analytics/components/throughput_table.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue index 590cdac1681c90..28b7e0848cc38f 100644 --- a/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue +++ b/ee/app/assets/javascripts/analytics/merge_request_analytics/components/throughput_table.vue @@ -288,7 +288,7 @@ export default { class="gl-font-weight-bold gl-text-gray-900" >{{ item.title }}</gl-link > - <ul class="horizontal-list gl-mt-2"> + <ul class="horizontal-list gl-mt-2 gl-mb-0"> <li class="gl-mr-3">{{ formatMergeRequestId(item.iid) }}</li> <li v-if="hasPipelineNodes(item) && item.pipelines.nodes.length" class="gl-mr-3"> <gl-icon -- GitLab