Move same EE ApplicationSetting validations to a single validation
What does this MR do and why?
We can pass multiple attributes to a single validation call. Therefore, we have moved the same validations to a single validation call which will reduce code duplication.
By default, numericality
option does not allow nil values so using
presence of is redundant.
See
https://guides.rubyonrails.org/active_record_validations.html#numericality.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #420321 (closed)
Merge request reports
Activity
changed milestone to %16.8
assigned to @abdwdd
added typefeature label
removed maintenancerefactor label
added typemaintenance label and removed typefeature label
- Resolved by Dylan Griffith
- Resolved by Dylan Griffith
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @wandering_person
(UTC+7, 1.5 hours ahead of author)
@igor.drozdov
(UTC+1, 4.5 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e6b7cf36expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 264 | 0 | 9 | 0 | 273 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Dylan Griffith
@wandering_person could you please do the initial review?
requested review from @wandering_person
requested review from @DylanGriffith
- Resolved by Dylan Griffith
@wandering_person
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 77af7aab succeeds
mentioned in commit 519d70fe
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels