Skip to content
Snippets Groups Projects

Move same EE ApplicationSetting validations to a single validation

Merged Abdul Wadood requested to merge 420321-refactor-validates-numericality-ee into master
All threads resolved!

What does this MR do and why?

We can pass multiple attributes to a single validation call. Therefore, we have moved the same validations to a single validation call which will reduce code duplication.

By default, numericality option does not allow nil values so using presence of is redundant. See https://guides.rubyonrails.org/active_record_validations.html#numericality.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #420321 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Contributor

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @wandering_person profile link current availability (UTC+7, 1.5 hours ahead of author) @igor.drozdov profile link current availability (UTC+1, 4.5 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for e6b7cf36

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Verify      | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Create      | 54     | 0      | 7       | 0     | 61    | ✅     |
    | Data Stores | 23     | 0      | 0       | 0     | 23    | ✅     |
    | Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
    | Package     | 15     | 0      | 1       | 0     | 16    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 264    | 0      | 9       | 0     | 273   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • requested review from @wandering_person

  • requested review from @DylanGriffith

  • Michael Becker approved this merge request

    approved this merge request

  • Dylan Griffith approved this merge request

    approved this merge request

  • Dylan Griffith resolved all threads

    resolved all threads

  • Dylan Griffith enabled an automatic merge when the pipeline for 77af7aab succeeds

    enabled an automatic merge when the pipeline for 77af7aab succeeds

  • merged

  • Dylan Griffith mentioned in commit 519d70fe

    mentioned in commit 519d70fe

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading