Replace milestone promotion banner with alert

What does this MR do and why?

• Replace the milestone promotion banner with an alert because there is nothing to promote. For information we use alerts.
• Fix bug when burndown chart was visible with no issues in a milestone.
• Fix bug when "no issues" alert was shown with one issue in a milestone.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

When	Before	After
Milestone is ready to be closed
No issues, no dates
No dates
No issues
Issues and dates

How to set up and validate locally

• Go to any empty milestone, for example http://gdk.test:3000/gitlab-org/gitlab-shell/-/milestones
• Create a milestone with no dates
• See a 'Add start and due date to view a burndown chart. Assign some issues to this milestone.' alert
• Add dates
• See 'Assign some issues to this milestone.' alert
• Remove dates
• Assign one issue to this milestone
• See 'Add start and due date to view a burndown chart.' alert
• Add dates
• See burndown/burnup charts and no alerts
• Close assigned issue
• Go back to milestone
• See All issues for this milestone are closed. You may close this milestone now. alert

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

#424397 (closed)

app/views/projects/milestones/show.html.haml

@@ -17,29 +17,6 @@
     - c.with_body do
       = _('All issues for this milestone are closed. You may close this milestone now.')
 
-- burndown_endpoint = @milestone.group_milestone? ? api_v4_groups_milestones_burndown_events_path(id: @milestone.group.id, milestone_id: @milestone.id) : api_v4_projects_milestones_burndown_events_path(id: @milestone.project.id, milestone_id: @milestone.timebox_id)
-- no_milestone_dates = show_burndown_placeholder?(@milestone)
-- no_milestone_issues = (can?(current_user, :read_issue, @group) || can?(current_user, :read_issue, @project)) && @milestone.issues_visible_to_user(current_user).count === 0
-
-- if no_milestone_dates || no_milestone_issues
-  = render Pajamas::AlertComponent.new(dismissible: false,
-    alert_options: { class: 'gl-mt-3 gl-mb-5',
-    data: { testid: 'no-issues-and-dates-alert' }}) do |c|
-    - c.with_body do
-      - if no_milestone_dates
-        - url = edit_milestone_path(@milestone)
-        = safe_format(_('%{link_start}Add a start date and due date%{link_end} to view a burndown chart.'), tag_pair(link_to('', url), :link_start, :link_end))
-      - if no_milestone_issues
-        = _('Assign some issues to this milestone.')
-
-- elsif can_generate_chart?(milestone)
-  - add_page_startup_graphql_call('burndown_chart/burnup', { id: @milestone.to_global_id.to_s, isIteration: false, weight: false })
-  .burndown-chart.mb-2{ data: { start_date: @milestone.start_date.iso8601,
-    due_date: @milestone.due_date.iso8601,
-    milestone_id: @milestone.to_global_id,
-    is_legacy: legacy_milestone?(@milestone),
-    burndown_events_path: expose_url(burndown_endpoint) } }
-
 = render_if_exists 'shared/milestones/burndown', milestone: @milestone, project: @project
 
 = render 'shared/milestones/tabs', milestone: @milestone