Replace milestone promotion banner with alert
-
Review changes -
-
Download -
Patches
-
Plain diff
All threads resolved!
All threads resolved!
What does this MR do and why?
- Replace the milestone promotion banner with an alert because there is nothing to promote. For information we use alerts.
- Fix bug when burndown chart was visible with no issues in a milestone.
- Fix bug when "no issues" alert was shown with one issue in a milestone.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
When | Before | After |
---|---|---|
Milestone is ready to be closed | ![]() |
![]() |
No issues, no dates | ![]() |
![]() |
No dates | ![]() |
![]() |
No issues | ![]() |
![]() |
Issues and dates | ![]() |
![]() |
How to set up and validate locally
- Go to any empty milestone, for example
http://gdk.test:3000/gitlab-org/gitlab-shell/-/milestones
- Create a milestone with no dates
- See a 'Add start and due date to view a burndown chart. Assign some issues to this milestone.' alert
- Add dates
- See 'Assign some issues to this milestone.' alert
- Remove dates
- Assign one issue to this milestone
- See 'Add start and due date to view a burndown chart.' alert
- Add dates
- See burndown/burnup charts and no alerts
- Close assigned issue
- Go back to milestone
- See
All issues for this milestone are closed. You may close this milestone now.
alert
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Julia Miocene
Merge request reports
Compare and
Show latest version
- version 344dbae575
- version 330a819013
- version 32350294bd
- version 31b39a38ca
- version 30804470d8
- version 29195d9c5d
- version 28b545ae3e
- version 2772eaab82
- version 269a814477
- version 253ab06c67
- version 24990f0563
- version 235e388aa8
- version 22a2637e7f
- version 21dfa0840b
- version 2004fca6a5
- version 1967227cba
- version 1812715697
- version 1753968896
- version 167c37b224
- version 154eda77d8
- version 14282bc5ea
- version 1323f8cac9
- version 12095dde34
- version 11142175bd
- version 10ffec0a77
- version 91a715cb8
- version 80c03c069
- version 7fd6c0119
- version 6db47c74a
- version 51574984d
- version 4f77c840a
- version 3c9330cc0
- version 2b6ba9497
- version 16def6e79
- master (base)
- latest versionc323a81e1 commit,
- version 344dbae5751 commit,
- version 330a8190133 commits,
- version 32350294bd2 commits,
- version 31b39a38ca2 commits,
- version 30804470d82 commits,
- version 29195d9c5d2 commits,
- version 28b545ae3e2 commits,
- version 2772eaab822 commits,
- version 269a8144772 commits,
- version 253ab06c672 commits,
- version 24990f05632 commits,
- version 235e388aa82 commits,
- version 22a2637e7f2 commits,
- version 21dfa0840b2 commits,
- version 2004fca6a52 commits,
- version 1967227cba2 commits,
- version 18127156972 commits,
- version 17539688962 commits,
- version 167c37b2242 commits,
- version 154eda77d83 commits,
- version 14282bc5ea3 commits,
- version 1323f8cac93 commits,
- version 12095dde343 commits,
- version 11142175bd3 commits,
- version 10ffec0a772 commits,
- version 91a715cb81 commit,
- version 80c03c0691 commit,
- version 7fd6c01191 commit,
- version 6db47c74a1 commit,
- version 51574984d1 commit,
- version 4f77c840a1 commit,
- version 3c9330cc01 commit,
- version 2b6ba94971 commit,
- version 16def6e791 commit,
Compare changes
- Side-by-side
- Inline
There are no changes yet
No changes between version 13 and version 13
Loading