Skip to content
Snippets Groups Projects

Replace milestone promotion banner with alert

Merged Julia Miocene requested to merge replace-milestone-banner-with-alert into master
Compare and Show latest version
1 file
+ 27
18
Compare changes
  • Side-by-side
  • Inline
@@ -4,32 +4,34 @@
RSpec.describe 'Burndown charts', :js, feature_category: :team_planning do
let(:current_user) { create(:user) }
let(:milestone) do
create(
:milestone,
project: project,
group: group,
start_date: Date.current,
due_date: Date.tomorrow
)
end
before do
sign_in(current_user)
end
describe 'for project milestones' do
let(:group) { nil }
let_it_be(:project, reload: true) { create(:project) }
let(:project) { create(:project) }
let(:milestone_1) { create(:milestone, start_date: Date.current, due_date: Date.tomorrow, project: project) }
let(:milestone_empty) { create(:milestone, start_date: nil, due_date: nil, project: project) }
before do
project.add_maintainer(current_user)
create(:issue, project: project, milestone: milestone_1)
end
it 'presents no issues alert' do
visit project_milestone_path(milestone_empty.project, milestone_empty)
expect(page).to have_content('Assign some issues to this milestone.')
end
it 'presents no dates alert' do
visit project_milestone_path(milestone_empty.project, milestone_empty)
expect(page).to have_content('Add start and due date')
end
it 'presents burndown charts when available' do
stub_licensed_features(milestone_charts: true)
visit project_milestone_path(milestone.project, milestone)
visit project_milestone_path(milestone_1.project, milestone_1)
expect(page).to have_css('.burndown-chart')
expect(page).to have_content('Burndown chart')
@@ -38,8 +40,7 @@
it 'presents burndown charts promotion correctly' do
stub_licensed_features(milestone_charts: false)
allow(License).to receive(:current).and_return(nil)
visit project_milestone_path(milestone.project, milestone)
visit project_milestone_path(milestone_1.project, milestone_1)
expect(page).not_to have_css('.burndown-chart')
expect(page).to have_content('Improve milestones with Burndown Charts')
@@ -48,16 +49,24 @@
describe 'for group milestones' do
let(:group) { create(:group) }
let(:project) { nil }
let(:project) { create(:project, group: group) }
let(:milestone_1) { create(:milestone, start_date: Date.current, due_date: Date.tomorrow, group: group) }
let(:milestone_empty) { create(:milestone, start_date: nil, due_date: nil, group: group) }
before do
group.add_maintainer(current_user)
create(:issue, milestone: milestone_1, project: project)
end
it 'presents no dates alert' do
visit group_milestone_path(milestone_empty.group, milestone_empty)
expect(page).to have_content('Add start and due date')
end
it 'presents burndown charts when available' do
stub_licensed_features(milestone_charts: true)
visit group_milestone_path(milestone.group, milestone)
visit group_milestone_path(milestone_1.group, milestone_1)
expect(page).to have_css('div.burndown-chart')
expect(page).to have_content('Burndown chart')
@@ -67,7 +76,7 @@
stub_licensed_features(milestone_charts: false)
allow(License).to receive(:current).and_return(nil)
visit group_milestone_path(milestone.group, milestone)
visit group_milestone_path(milestone_1.group, milestone_1)
expect(page).not_to have_css('.burndown-chart')
expect(page).to have_content('Improve milestones with Burndown Charts')
Loading