Improve text related to custom roles

changed milestone to %16.5

added frontend groupauthentication and authorization [DEPRECATED] maintenancerefactor typemaintenance labels

assigned to @eduardosanz

added devopsgovern sectionsec labels

changed the description

@jglassman1, would you mind reviewing this MR?

Thanks!

requested review from @jglassman1

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Stanislav Lashmanov (`@slashmanov`) (UTC+4, 2 hours ahead of `@eduardosanz`)	Jacques Erasmus (`@jerasmus`) (UTC+2, same timezone as `@eduardosanz`)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 2ac6729e and c14e1a16

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.23 MB	4.23 MB	-	-0.0 %
mainChunk	3.1 MB	3.1 MB	-	0.0 %

Note: We do not have exact data for 2ac6729e. So we have used data from: 4686cfb8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for c14e1a16

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Verify      | 8      | 0      | 0       | 0     | 8     | ✅     |
| Govern      | 35     | 0      | 1       | 0     | 36    | ✅     |
| Plan        | 51     | 0      | 0       | 0     | 51    | ✅     |
| Create      | 37     | 0      | 1       | 0     | 38    | ✅     |
| Data Stores | 18     | 0      | 2       | 0     | 20    | ✅     |
| Manage      | 12     | 0      | 1       | 0     | 13    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 161    | 0      | 5       | 0     | 166   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: test report for c14e1a16

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Govern           | 34     | 0      | 1       | 0     | 35    | ✅     |
| Create           | 8      | 0      | 1       | 1     | 9     | ❗     |
| Monitor          | 4      | 0      | 0       | 1     | 4     | ❗     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Data Stores      | 1      | 0      | 1       | 0     | 2     | ✅     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 51     | 0      | 6       | 2     | 57    | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

@eduardosanz, please can you answer the question: Should this have a feature flag? to help with code review for the Authentication and Authorization group.

This nudge was added by this triage-ops policy.

added 1 commit

b1717422 - Apply suggestion from tech writer

Compare with previous version

approved this merge request

Thanks @eduardosanz LGTM. Approving but not merging as I do not have permission.

@jglassman1, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

Hi @jglassman1 ,

GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.

This message was generated automatically. You're welcome to improve it.

added Technical Writing label

@eduardosanz Some end-to-end (E2E) tests should run based on the stage label.

Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure tests in the follow-up-e2e:package-and-test-ee pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

Once done, apply the emoji on this comment.

Team members only: for any questions or help, reach out on the internal #quality Slack channel.

added 1330 commits

b1717422...9a44072f - 1329 commits from branch master
923512ca - Improve text related to custom roles

Compare with previous version

added 1 commit

38fe1967 - Improve text related to custom roles

Compare with previous version

@jerasmus, would you mind maintenerasing this MR? This is a change in some strings, and I think another approval (on top of the technical writer) is enough. Thanks!

requested review from @jerasmus

Slow tests detected in this merge request, might be related with changed RSpec files.

Job	File	Name	Duration	Expected duration
#5177732856	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.76 s	< 45.4 s
#5177732856	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.16 s	< 45.4 s
#5177732856	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.18 s	< 45.4 s
#5182005798	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.8 s	< 45.4 s
#5182005798	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.19 s	< 45.4 s
#5182005798	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.17 s	< 45.4 s
#5182536188	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.7 s	< 45.4 s
#5182536188	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.24 s	< 45.4 s
#5182536188	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.19 s	< 45.4 s
#5183449520	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.72 s	< 45.4 s
#5183449520	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.19 s	< 45.4 s
#5183449520	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.23 s	< 45.4 s
#5199360057	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.74 s	< 45.4 s
#5199360057	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.12 s	< 45.4 s
#5199360057	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.25 s	< 45.4 s
#5200782271	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.76 s	< 45.4 s
#5200782271	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.22 s	< 45.4 s
#5200782271	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.2 s	< 45.4 s
#5209362575	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.75 s	< 45.4 s
#5209362575	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.1 s	< 45.4 s
#5209362575	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.19 s	< 45.4 s
#5218998539	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.75 s	< 45.4 s
#5218998539	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.15 s	< 45.4 s
#5218998539	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.17 s	< 45.4 s
#5221047522	`spec/models/member_spec.rb#L1041`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group create member when lease cannot be obtained only schedules one job	59.75 s	< 45.4 s
#5221047522	`spec/models/member_spec.rb#L1051`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists update member when access level was changed when lease is obtained schedules a job in the future	60.23 s	< 45.4 s
#5221047522	`spec/models/member_spec.rb#L1064`	Member when after_commit :update_highest_role member_type: :group_member, source_type: :group when member exists destroy member when lease is obtained schedules a job in the future	60.25 s	< 45.4 s