Delete usersstarreddashboard create and delete service
What does this MR do and why?
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #397139 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @rkadam3
1 Warning b2376a4a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ian Anderson (
@imand3r
) (UTC-7, 12.5 hours behind@rkadam3
)Drew Cimino (
@drew
) (UTC+0, 5.5 hours behind@rkadam3
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @rkadam3 Some end-to-end (E2E) tests have been selected based on the stage label on this MR.Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing before this MR is merged. (The E2E test pipeline is computationally intensive and we cannot afford running it automatically for all pushes/rebases. Therefore, this job must be triggered manually after significant changes at least once.)If you would like to run all E2E tests, please apply the pipeline:run-all-e2e label and trigger a new pipeline. This will run all tests in
e2e:package-and-test
pipeline.The E2E test jobs are allowed to fail due to flakiness. For the list of known failures please refer to the latest pipeline triage issue.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d9b2ca11expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 0 | 5 | 51 | ❗ | | Data Stores | 22 | 0 | 0 | 5 | 22 | ❗ | | Govern | 36 | 0 | 0 | 6 | 36 | ❗ | | Manage | 13 | 0 | 1 | 12 | 14 | ❗ | | Create | 46 | 0 | 1 | 7 | 47 | ❗ | | Verify | 8 | 0 | 0 | 2 | 8 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 180 | 0 | 4 | 37 | 184 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for d9b2ca11expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 535 | 24 | 85 | 24 | 644 | ❌ | | Package | 232 | 0 | 11 | 0 | 243 | ✅ | | Verify | 141 | 0 | 18 | 3 | 159 | ❗ | | Data Stores | 117 | 0 | 3 | 0 | 120 | ✅ | | Monitor | 36 | 0 | 7 | 0 | 43 | ✅ | | Plan | 246 | 0 | 10 | 0 | 256 | ✅ | | Govern | 155 | 3 | 12 | 9 | 170 | ❌ | | Release | 18 | 0 | 0 | 0 | 18 | ✅ | | Manage | 158 | 0 | 13 | 25 | 171 | ❗ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | ModelOps | 0 | 0 | 3 | 0 | 3 | ➖ | | Fulfillment | 8 | 0 | 72 | 0 | 80 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 6 | 0 | 12 | 0 | 18 | ✅ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1670 | 27 | 267 | 61 | 1964 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Vitali Tatarintev
@ck3g - Mind taking a direct maintainer look on this one, please?
requested review from @ck3g
added pipeline:run-all-e2e label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@ck3g
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit 5645fb75
added workflowstaging-canary label and removed workflowblocked label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label