Skip to content
Snippets Groups Projects

Migrate to GlCollapsibleListbox in work_item_activity_sort_filter

All threads resolved!

What does this MR do and why?

Migrate to GlCollapsibleListbox in work_item_activity_sort_filter

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-08-10_at_2.56.45_PM Screenshot_2023-08-10_at_2.56.16_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to any work item
  2. Use the activity filters and make sure they are synced in local storage when you visit again
  3. No changes in current functionality

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418040 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added frontend label

  • Contributor
    1 Warning
    :warning: This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.

    Testid Selectors

    The following changed lines in this MR contain testid selectors:

    • file app/assets/javascripts/work_items/components/notes/work_item_activity_sort_filter.vue:
      •    v-for="{ text, key, testid } in filterOptions"
      •    :data-testid="testid"
    • file app/assets/javascripts/work_items/constants.js:
      • testid: 'comments-activity',
      • testid: 'history-activity',
      • { key: DESC, text: __('Newest first'), testid: 'newest-first' },

    If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

    For the list of known failures please refer to the latest pipeline triage issue.

    If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Paulina Sedlak-Jakubowska current availability (@psjakubowska) (UTC+2, 3.5 hours behind @deepika.guliani) Savas Vedova current availability (@svedova) (UTC+2, 3.5 hours behind @deepika.guliani)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • requested review from @psjakubowska

  • Deepika Guliani changed milestone to %16.4

    changed milestone to %16.4

  • Deepika Guliani changed milestone to %16.3

    changed milestone to %16.3

  • Contributor

    :warning: @deepika.guliani Some end-to-end (E2E) tests have been selected based on the stage label on this MR.

    Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing before this MR is merged. (The E2E test pipeline is computationally intensive and we cannot afford running it automatically for all pushes/rebases. Therefore, this job must be triggered manually after significant changes at least once.)

    If you would like to run all E2E tests, please apply the pipeline:run-all-e2e label and trigger a new pipeline. This will run all tests in e2e:package-and-test pipeline.

    The E2E test jobs are allowed to fail due to flakiness. For the list of known failures please refer to the latest pipeline triage issue.

    Once done, please apply the :white_check_mark: emoji on this comment.

    For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 7a5e187a and 429622ca

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.17 MB 4.17 MB - -0.0 %
    mainChunk 3.02 MB 3.02 MB - 0.0 %

    Note: We do not have exact data for 7a5e187a. So we have used data from: 292b8c22.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 429622ca

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 51     | 0      | 0       | 0     | 51    | ✅     |
    | Manage           | 13     | 0      | 1       | 1     | 14    | ❗     |
    | Create           | 46     | 0      | 1       | 2     | 47    | ❗     |
    | Govern           | 36     | 0      | 0       | 0     | 36    | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Verify           | 8      | 0      | 0       | 0     | 8     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 180    | 0      | 4       | 3     | 184   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :white_check_mark: test report for 429622ca

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 20     | 0      | 4       | 0     | 24    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 429622ca

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Data Stores      | 117    | 0      | 3       | 0     | 120   | ✅     |
    | Plan             | 246    | 0      | 10      | 0     | 256   | ✅     |
    | Verify           | 141    | 0      | 15      | 0     | 156   | ✅     |
    | Create           | 557    | 2      | 89      | 52    | 648   | ❌     |
    | Package          | 226    | 0      | 17      | 0     | 243   | ✅     |
    | Govern           | 167    | 0      | 3       | 6     | 170   | ❗     |
    | Manage           | 158    | 0      | 13      | 25    | 171   | ❗     |
    | Systems          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Fulfillment      | 8      | 0      | 72      | 0     | 80    | ✅     |
    | Monitor          | 36     | 0      | 7       | 0     | 43    | ✅     |
    | ModelOps         | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Secure           | 6      | 0      | 12      | 0     | 18    | ✅     |
    | Release          | 18     | 0      | 0       | 0     | 18    | ✅     |
    | Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 1698   | 2      | 268     | 83    | 1968  | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Paulina Sedlak-Jakubowska approved this merge request

    approved this merge request

  • Paulina Sedlak-Jakubowska requested review from @mrincon and removed review request for @psjakubowska

    requested review from @mrincon and removed review request for @psjakubowska

  • :wave: @psjakubowska, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Miguel Rincon
  • Miguel Rincon removed review request for @mrincon

    removed review request for @mrincon

  • Deepika Guliani added 1465 commits

    added 1465 commits

    Compare with previous version

  • Deepika Guliani requested review from @mrincon

    requested review from @mrincon

  • 🤖 GitLab Bot 🤖 changed milestone to %16.4

    changed milestone to %16.4

  • Miguel Rincon approved this merge request

    approved this merge request

  • Miguel Rincon resolved all threads

    resolved all threads

  • Miguel Rincon enabled an automatic merge when the pipeline for ed2042f7 succeeds

    enabled an automatic merge when the pipeline for ed2042f7 succeeds

  • merged

  • Miguel Rincon mentioned in commit 3b5be0e2

    mentioned in commit 3b5be0e2

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading