Exclude archived projects from blob search

What does this MR do and why?

Exclude archived projects from blob search

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

• Make sure advanced search is enabled.
• Add a commit with some specific message like foobar on 2 projects
• Archive one of the projects from project settings
• Now search for foobar. You should see the results from both projects under projects
• Now enable the feature-flag search_blob_hide_archived_projects
• Now search again, you should see the results from only non-archived project
• Repeat the same steps and test for group search as well.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #414901 (closed)

ee/spec/lib/gitlab/elastic/group_search_results_spec.rb

@@ -69,52 +69,26 @@
       before do
         unarchived_project.repository.index_commits_and_blobs
         archived_project.repository.index_commits_and_blobs
+
         ensure_elasticsearch_index!
-      end
 
-      let_it_be(:owner) { create(:user) }
-      let_it_be(:unarchived_project) { create(:project, :public, :repository, group: group, creator: owner) }
-      let_it_be(:archived_project) { create(:project, :archived, :repository, :public, group: group, creator: owner) }
-      let_it_be(:unarchived_result_object) do
-        unarchived_project.repository.create_file(owner, 'test.rb', '# magik', message: 'magik', branch_name: 'master')
-      end
+        allow(Gitlab::Search::FoundBlob).to receive(:new).and_return(instance_double(Gitlab::Search::FoundBlob))
 
-      let_it_be(:archived_result_object) do
-        archived_project.repository.create_file(owner, 'test.rb', '# magik', message: 'magik', branch_name: 'master')
-      end
+        allow(Gitlab::Search::FoundBlob).to receive(:new)
+          .with(a_hash_including(project_id: unarchived_project.id, ref: unarchived_project.commit.id)).and_return(unarchived_result)
 
-      let(:unarchived_blob) { unarchived_project.repository.blob_at('HEAD', 'test.rb') }
-      let(:archived_blob) { archived_project.repository.blob_at('HEAD', 'test.rb') }
-      let(:unarchived_result) do
-        Gitlab::Search::FoundBlob.new(
-          path: unarchived_blob.path,
-          basename: './test',
-          ref: unarchived_project.commit.id,
-          matched_lines_count: 0,
-          data: unarchived_blob.data,
-          group: group,
-          project: unarchived_project,
-          project_id: unarchived_project.id,
-          highlight_line: 1,
-          startline: 1)
+        allow(Gitlab::Search::FoundBlob).to receive(:new)
+          .with(a_hash_including(project_id: archived_project.id, ref: archived_project.commit.id)).and_return(archived_result)
       end
 
-      let(:archived_result) do
-        Gitlab::Search::FoundBlob.new(
-          path: archived_blob.path,
-          basename: './test',
-          ref: archived_project.commit.id,
-          matched_lines_count: 0,
-          data: archived_blob.data,
-          project: archived_project,
-          group: group,
-          project_id: archived_project.id,
-          highlight_line: 1,
-          startline: 1)
-      end
+      let_it_be(:unarchived_project) { create(:project, :public, :repository, group: group) }
+      let_it_be(:archived_project) { create(:project, :archived, :repository, :public, group: group) }
+
+      let(:unarchived_result) { instance_double(Gitlab::Search::FoundBlob, project: unarchived_project) }
+      let(:archived_result) { instance_double(Gitlab::Search::FoundBlob, project: archived_project) }
 
       let(:scope) { 'blobs' }
-      let(:query) { 'magik' }
+      let(:query) { 'something went wrong' }
 
       include_examples 'search results filtered by archived', 'search_blobs_hide_archived_projects'
     end