Resolve "Verify JWT audience in internal Kubernetes Agent API endpoint"

changed milestone to %16.3

added devopsdeploy environmentsbacklog featureenhancement groupenvironments quick win sectioncd typefeature workflowin dev labels

assigned to @timofurrer

added 1 commit

08736379 - WIP: Verify JWT audience in token sent by KAS

Compare with previous version

added backend label

1 Warning

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Alishan 'Ali' Ladhani (`@ali-gitlab`) (UTC+0, 2 hours behind `@timofurrer`)	Douglas Barbosa Alexandre (`@dbalexandre`) (UTC+0, 2 hours behind `@timofurrer`)
~"group::authentication and authorization"	Reviewer review is optional for ~"group::authentication and authorization"	Jarka Košanová (`@jarka`) (UTC+2, same timezone as `@timofurrer`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

60274814 - Verify JWT audience in token sent by KAS

Compare with previous version

added 1 commit

5562067b - Verify audience in JWT token sent by KAS

Compare with previous version

removed environmentsbacklog label

added 1 commit

e96622e4 - Verify audience in JWT token sent by KAS

Compare with previous version

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 621c6cdd

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Manage           | 13     | 0      | 1       | 12    | 14    | ❗     |
| Plan             | 51     | 0      | 0       | 44    | 51    | ❗     |
| Govern           | 21     | 0      | 0       | 18    | 21    | ❗     |
| Create           | 27     | 0      | 1       | 20    | 28    | ❗     |
| Data Stores      | 22     | 0      | 0       | 15    | 22    | ❗     |
| Verify           | 8      | 0      | 0       | 8     | 8     | ❗     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 146    | 0      | 3       | 117   | 149   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+