Hide analytics dashboards from guest
All threads resolved!
All threads resolved!
Compare changes
There are no changes yet
No changes between version 5 and version 5
This MR has 2 commits, each one explained below. I recommend we merge without squashing.
1. Simplify Analytics Dashboard tests
Analytics Dashboard
feature tests had different context
blocks based on several feature flag values and then calling shared product analytics dashboards
tests. However, those shared examples already testing the same scenarios. So I cleaned them up before making changes to the access requirement.
2. Hide analytics dashboards unless has permission
Analytics dashboards in public projects are currently accessible to any user (including guest). However, they should only be visible to users who have at least developer
role in the project. This is fixed with this MR.
Changes
Note: A changelog trailer is not added as the feature is behind a flag.
The following screenshots are taken as a not logged in user in a public project.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #413980 (closed)
No changes between version 5 and version 5