Remove data-qa-selectors from secure/security_dashboard.rb

changed milestone to %16.2

added frontend label

	2 Warnings
	This merge request contains lines with QA selectors. Please ensure `e2e:package-and-test` job is run.
	Please add a merge request subtype to this merge request.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

QA Selectors

The following changed lines in this MR contain QA selectors:

file ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/selection_summary.vue:

     data-qa-selector="vulnerability_card_status_dropdown"

         :data-qa-selector="`item_status_${item.action}`"

     data-qa-selector="change_status_button"

file ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/vulnerability_list.vue:

     data-qa-selector="vulnerability_report_checkbox_all"

     data-qa-selector="vulnerability_status_content"

- ```
       data-qa-selector="vulnerability"
```

       data-qa-selector="vulnerability_issue_created_badge_content"

       data-qa-selector="false_positive_vulnerability"

       data-qa-selector="vulnerability_remediated_badge_content"

file ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/vulnerability_report_header.vue:

   data-qa-selector="export_vulnerabilities_button"

Please ensure e2e:package-and-test job is run and the tests are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Rudy Crespo (`@rcrespo3`) (UTC-4, 14 hours behind `@hmuralidhar`)	Natalia Tepluhina (`@ntepluhina`) (UTC+2, 8 hours behind `@hmuralidhar`)
QA	John McDonnell (`@john.mcdonnell`) (UTC+1, 9 hours behind `@hmuralidhar`)	Mark Lapierre (`@mlapierre`) (UTC+10, same timezone as `@hmuralidhar`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 8617a15a and 693caa53

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.14 MB	4.14 MB	-	-0.0 %
mainChunk	3 MB	3 MB	-	0.0 %

Note: We do not have exact data for 8617a15a. So we have used data from: ed250dcd.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 693caa53

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 4      | 0      | 0       | 3     | 4     | ❗     |
| Create           | 8      | 0      | 1       | 6     | 9     | ❗     |
| Monitor          | 4      | 0      | 0       | 4     | 4     | ❗     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 21     | 0      | 2       | 13    | 23    | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: test report for 693caa53

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 8      | 0      | 1       | 1     | 9     | ❗     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 20     | 0      | 3       | 1     | 23    | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 693caa53

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 488    | 0      | 77      | 8     | 565   | ❗     |
| Manage           | 142    | 1      | 27      | 8     | 170   | ❌     |
| Verify           | 147    | 0      | 15      | 3     | 162   | ❗     |
| Plan             | 243    | 0      | 1       | 0     | 244   | ✅     |
| Data Stores      | 117    | 0      | 3       | 0     | 120   | ✅     |
| Package          | 232    | 0      | 9       | 24    | 241   | ❗     |
| Fulfillment      | 8      | 0      | 75      | 0     | 83    | ✅     |
| Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
| Release          | 18     | 0      | 0       | 0     | 18    | ✅     |
| Govern           | 149    | 0      | 9       | 0     | 158   | ✅     |
| ModelOps         | 0      | 0      | 3       | 0     | 3     | ➖     |
| Monitor          | 36     | 0      | 7       | 0     | 43    | ✅     |
| Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
| Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Systems          | 11     | 0      | 0       | 0     | 11    | ✅     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
| Secure           | 6      | 0      | 27      | 0     | 33    | ✅     |
| Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 1607   | 1      | 274     | 43    | 1882  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

added 2 commits

4991d3b6 - Remove dynamic data-qa-selector which was not being used
693caa53 - Lint error fix

Compare with previous version

marked this merge request as ready

changed title from Draft: Change data-qa-selector to data-testid to Remove data-qa-selectors from secure/security_dashboard.rb

changed the description

requested review from @john.mcdonnell

requested review from @rcrespo3

@rcrespo3 could you please review for frontend ?

@john.mcdonnell could you please review for QA ?

approved this merge request

@john.mcdonnell, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

removed review request for @john.mcdonnell

approved this merge request

requested review from @ntepluhina and removed review request for @rcrespo3

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 71c06c82 succeeds

merged

mentioned in commit 1fa7ff71

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

Remove data-qa-selectors from secure/security_dashboard.rb

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Activity

QA Selectors

Reviewer roulette

Bundle size analysis [beta]

Special assets

Allure report

Remove data-qa-selectors from secure/security_dashboard.rb

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Merge request reports

Activity

QA Selectors

Reviewer roulette

Bundle size analysis [beta]

Special assets

Allure report