Fix status filter removal
What does this MR do and why?
This MR fixes an issue where it's not possible to add the status filter again after removing it. The bug was introduced here: Generalize filter selector (!123329 - merged).
Screenshots or screen recordings
Before | After |
---|---|
status_filter_removal_before | status_filter_removal_after |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #412790 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @mcavoj
added bugfunctional typebug labels and removed typefeature label
- Resolved by Alexander Turinske
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend James Rushford (
@jrushford
) (UTC+2)Phil Hughes (
@iamphill
) (UTC+1)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Alexander Turinske
Hi @aturinske
Could you please review this bug fix?
requested review from @aturinske
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 14bfdd9d and e8791d01
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - 0.0 % mainChunk 3 MB 3 MB - 0.0 %
Note: We do not have exact data for 14bfdd9d. So we have used data from: a216297d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger@aturinske
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 218b656b succeeds
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e8791d01expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for e8791d01expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 17 | 4 | 0 | 0 | 21 | ❌ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 5 | 3 | 1 | 0 | 9 | ❌ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 32 | 7 | 3 | 1 | 42 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 4ae58c47
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label