Resolve "UX update: default framework"
What does this MR do and why?
Removes the seperate badge for default compliance frameworks. Adds (default)
to the compliance framework name when it is default.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Navigate to compliance frameworks settings and add both a default and not framework
- Confirm that both default and not labels display correctly
- Navigate to compliance framework report
- Confirm that both default and not labels display correctly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #411591 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @nrosandich
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains lines with QA selectors. Please ensure e2e:package-and-test
job is run.QA Selectors
The following changed lines in this MR contain QA selectors:
- file
ee/app/assets/javascripts/compliance_dashboard/components/shared/framework_badge.vue
: -
-
data-qa-selector="framework_badge"
-
Please ensure
e2e:package-and-test
job is run and the tests are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Scott de Jonge (
@sdejonge
) (UTC+10)Michael Lunøe (
@mlunoe
) (UTC+2)QA Jay McCure (
@jay_mccure
) (UTC+10)Maintainer review is optional for QA UX Matthew Nearents (
@mnearents
) (UTC-7)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %16.1
- Resolved by Nate Rosandich
@mlapierre would you be able to help me on this one? We are removing the default badge and it looks like there is a
data-qa-selector
on it that was being used.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 0912ba84 and 3c446777
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - -0.0 % mainChunk 3 MB 3 MB - 0.0 %
Note: We do not have exact data for 0912ba84. So we have used data from: a216297d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Mark Lapierre
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3c446777expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 3c446777expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 3c446777expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Plan | 390 | 0 | 3 | 0 | 393 | ✅ | | Create | 688 | 0 | 117 | 5 | 805 | ❗ | | Manage | 208 | 16 | 17 | 28 | 241 | ❌ | | Govern | 245 | 5 | 5 | 5 | 255 | ❌ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Package | 162 | 0 | 15 | 141 | 177 | ❗ | | Verify | 250 | 0 | 25 | 0 | 275 | ✅ | | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2265 | 21 | 404 | 179 | 2690 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- A deleted user
added QA label
added 195 commits
-
28e192d2...e8424d15 - 194 commits from branch
master
- 3c446777 - Move default into framework name
-
28e192d2...e8424d15 - 194 commits from branch
- Resolved by Michael Lunøe
requested review from @sdejonge
- Resolved by Michael Lunøe
requested review from @cam.x
- Resolved by Michael Lunøe
@mlapierre can you please do the QA review?
requested review from @mlapierre
mentioned in issue #411591 (closed)
@sdejonge
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in design management/design #412702 (closed)[list-view-by-frameworks.png]
removed review request for @mlapierre
- Resolved by Nate Rosandich
enabled an automatic merge when the pipeline for 376ec61a succeeds
mentioned in issue gitlab-org/quality/pipeline-triage#202 (closed)
mentioned in commit e9fc844d
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
mentioned in issue #415407
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in issue gitlab-org/quality/pipeline-triage#203 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
mentioned in issue gitlab-org/quality/pipeline-triage#204 (closed)
added releasedpublished label and removed releasedcandidate label