Skip to content
Snippets Groups Projects

Resolve "UX update: default framework"

Merged Nate Rosandich requested to merge 411591-ux-update-default-framework into master
All threads resolved!

What does this MR do and why?

Removes the seperate badge for default compliance frameworks. Adds (default) to the compliance framework name when it is default.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Compliance-report--Sam-s-test-group--GitLab Compliance-report--Gitlab-Org--GitLab
General-settings--Settings--Sam-s-test-group-_-GitLab General-settings--Settings--Gitlab-Org-_-GitLab

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Navigate to compliance frameworks settings and add both a default and not framework
    1. https://docs.gitlab.com/ee/user/group/compliance_frameworks.html
  2. Confirm that both default and not labels display correctly
  3. Navigate to compliance framework report
    1. https://docs.gitlab.com/ee/user/compliance/compliance_report/#compliance-frameworks-report
  4. Confirm that both default and not labels display correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411591 (closed)

Edited by Nate Rosandich

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael Lunøe approved this merge request

    approved this merge request

  • Michael Lunøe resolved all threads

    resolved all threads

  • Michael Lunøe enabled an automatic merge when the pipeline for 376ec61a succeeds

    enabled an automatic merge when the pipeline for 376ec61a succeeds

  • merged

  • Michael Lunøe mentioned in commit e9fc844d

    mentioned in commit e9fc844d

  • Nate Rosandich resolved all threads

    resolved all threads

  • Nate Rosandich mentioned in issue #415407

    mentioned in issue #415407

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading