Show list of stream audit event types in UI
-
Review changes -
-
Download -
Patches
-
Plain diff
What does this MR do and why?
Relates to #413581 (closed)
This MR displays available audit event types coming from backend (HAML injected) in a GlCollapsibleListbox in the event filtering section of a streaming destination.
Before, each event type had to be created via the API and could only be unchecked via the UI later.
Some notes:
- The list of events is quite long, in next iterations, the listbox will handle grouping by category and searching.
- The event types don't have any label supplied, so it was decided that we would use sentence case;
"add_gpg_key"
becomes"Add gpg key"
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Make sure you have an EE license
- Go to any group
- Go to "Secure" > "Audit events"
- Click "Streams" tab
- Create a new streaming destination by clicking "Add streaming destination"
- Provide a "Destination URL"
- Validate you see the "Filter by stream event" accordion and click it
- Validate you see a dropdown with a placeholder "Select events", click it
- Validate you can see a long list of event types and these are selectable
- Validate that if you select some it updates the text of the dropdown button with a comma-separated list of the event type names
- Validate that clicking "Unselect all", actually unselects all event types
- Validate that clicking "Select all" selects all event types (button is only shown if no event types are selected)
- Select some event types and click "Add"
- Validate that the editor is closed and a new streaming destination is added
- Validate that if you edit that new destination and go to event type dropdown the same events are selected from before.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Lorenz van Herwaarden
Merge request reports
Compare and
- version 19839ef634
- version 18233ac5ff
- version 1729db487d
- version 161555306a
- version 15076b1a61
- version 140b927050
- version 13ed091554
- version 126516b47f
- version 11b5b18d12
- version 10cc2851fd
- version 9608a997f
- version 87fe4748d
- version 795cd0286
- version 66cc3e104
- version 5d08b685b
- version 441812300
- version 3a7f87f5f
- version 268644877
- version 158c787dd
- master (base)
- latest versiondbc33b3d11 commits,
- version 19839ef63413 commits,
- version 18233ac5ff12 commits,
- version 1729db487d11 commits,
- version 161555306a10 commits,
- version 15076b1a619 commits,
- version 140b9270508 commits,
- version 13ed0915547 commits,
- version 126516b47f6 commits,
- version 11b5b18d127 commits,
- version 10cc2851fd6 commits,
- version 9608a997f5 commits,
- version 87fe4748d4 commits,
- version 795cd02865 commits,
- version 66cc3e1044 commits,
- version 5d08b685b6 commits,
- version 4418123004 commits,
- version 3a7f87f5f3 commits,
- version 26864487712 commits,
- version 158c787dd11 commits,
Compare changes
- Side-by-side
- Inline
Files
16Loading