Reset webpack path for Mermaid iFrames
All threads resolved!
All threads resolved!
Compare changes
Files
4@@ -72,11 +72,14 @@ function fixElementSource(el) {
Fixes #413596 (closed)
This MR sets correct webpack path for Mermaid iFrames to render it correctly. This was broken after this upgrade: !115885 (merged) possibly because it tries to load more chunks.
The sandbox iFrame loads on a separate origin which doesn't have access to gon.relative_url_root
to load the webpack chunk properly.
Before | After |
---|---|
![]() |
![]() |
Example:
graph LR
A(GitLab Rails) -- Writes new pages deployment --> B[(NFS)]
C(GitLab Pages) -. Reads static content .-> B
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.