Remove Feature Flag for Deployments API breaking change
What does this MR do and why?
The Deployments API "list deployments" endpoint return an error response if updated_at is used for sorting but not
for filtering (#328500 (closed)). This behavior is behind a Feature Flag (!116656 (diffs)). It is enabled by default and there is another Feature Flag introduced to easily override it (!120066 (merged)).
This MR removes both the Feature Flag for the breaking change and the Feature Flag to override it.
Feature Flag issue: #409584 (closed)
Feature Flag rollback issue: #410663 (closed)
Screenshots or screen recordings
| Before | After |
|---|---|
 Here, the Feature Flag is enabled, but override is also enabled. This is the old behavior. |
 |
How to set up and validate locally
-
Pick any project that has a Deployment, or create a new test project and run a deploy pipeline (guide: https://docs.gitlab.com/ee/ci/environments/#environments-and-deployments)
-
Create an access token to use for API requests (guide: https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html#personal-access-tokens)
-
Run the following request from the terminal:
curl -ki -X GET \ --header "Authorization: Bearer $ACCESS_TOKEN" \ "https://gdk.test:3443/api/v4/projects/21/deployments?updated_after=2019-03-15T08:00:00Z"The request should have an error response.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #410663 (closed)