Skip to content
Snippets Groups Projects

Deterministic ordering of group value streams

Merged charlie ablett requested to merge 406357-cablett-value-stream-ordering into master
All threads resolved!

What does this MR do and why?

Deterministic ordering of value streams

Adds case-insensitive alphabetical ordering so value streams are more deterministic.

How to set up and validate locally

  1. In a group or project, create some value streams with slightly different names, different cases (e.g. Aaa, aaa, Bbb)
  2. Visit Analytics -> Value Stream for that group (or a project)
  3. Click the dropdown of value stream names and see the ordering.

image

database things

The introduced scope results in the following:

SELECT "analytics_cycle_analytics_group_value_streams".*
FROM "analytics_cycle_analytics_group_value_streams"
ORDER BY LOWER("analytics_cycle_analytics_group_value_streams"."name") ASC

https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/18829/commands/62659

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #406357 (closed)

Edited by charlie ablett

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    1 Warning
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Madelein van Niekerk current availability (@maddievn) (UTC+2, 10 hours behind @cablett) Mark Chao current availability (@lulalala) (UTC+8, 4 hours behind @cablett)
    database Prabakaran Murugesan current availability (@praba.m7n) (UTC+2, 10 hours behind @cablett) Mayra Cabrera current availability (@mayra-cabrera) (UTC-6, 18 hours behind @cablett)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • charlie ablett changed the description

    changed the description

  • charlie ablett resolved all threads

    resolved all threads

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for aecd3f6a

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • charlie ablett added 1 commit

    added 1 commit

    • 8c280ed6 - Deterministic ordering of value streams

    Compare with previous version

  • charlie ablett
  • charlie ablett changed the description

    changed the description

  • charlie ablett added 1 commit

    added 1 commit

    • 9d4f92d9 - Deterministic ordering of value streams

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • aecd3f6a - Deterministic ordering of value streams

    Compare with previous version

  • charlie ablett changed title from Deterministic ordering of value streams to Deterministic ordering of group value streams

    changed title from Deterministic ordering of value streams to Deterministic ordering of group value streams

  • added database label

  • charlie ablett requested review from @felipe_artur

    requested review from @felipe_artur

  • Felipe Cardozo approved this merge request

    approved this merge request

  • :wave: @felipe_artur, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • A deleted user added databasereview pending label
  • charlie ablett requested review from @dskim_gitlab

    requested review from @dskim_gitlab

  • Sincheol (David) Kim approved this merge request

    approved this merge request

  • Sincheol (David) Kim requested review from @ahegyi and removed review request for @dskim_gitlab

    requested review from @ahegyi and removed review request for @dskim_gitlab

  • charlie ablett requested review from @ayufan

    requested review from @ayufan

  • added databaseapproved label and removed databasereviewed label

  • Adam Hegyi
  • Adam Hegyi approved this merge request

    approved this merge request

  • Kamil Trzciński approved this merge request

    approved this merge request

  • Kamil Trzciński resolved all threads

    resolved all threads

  • Kamil Trzciński enabled an automatic merge when the pipeline for 74d9ef55 succeeds

    enabled an automatic merge when the pipeline for 74d9ef55 succeeds

  • Hello @cablett :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Kamil Trzciński mentioned in commit 0ff4d972

    mentioned in commit 0ff4d972

  • added workflowstaging label and removed workflowcanary label

  • Author Developer

    Verified on production :thumbsup:

  • Please register or sign in to reply
    Loading