Deterministic ordering of group value streams
What does this MR do and why?
Deterministic ordering of value streams
Adds case-insensitive alphabetical ordering so value streams are more deterministic.
How to set up and validate locally
- In a group or project, create some value streams with slightly different names, different cases (e.g. Aaa, aaa, Bbb)
- Visit
Analytics
->Value Stream
for that group (or a project) - Click the dropdown of value stream names and see the ordering.
database things
The introduced scope results in the following:
SELECT "analytics_cycle_analytics_group_value_streams".*
FROM "analytics_cycle_analytics_group_value_streams"
ORDER BY LOWER("analytics_cycle_analytics_group_value_streams"."name") ASC
https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/18829/commands/62659
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #406357 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @cablett
- Resolved by charlie ablett
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Madelein van Niekerk (
@maddievn
) (UTC+2, 10 hours behind@cablett
)Mark Chao (
@lulalala
) (UTC+8, 4 hours behind@cablett
)database Prabakaran Murugesan (
@praba.m7n
) (UTC+2, 10 hours behind@cablett
)Mayra Cabrera (
@mayra-cabrera
) (UTC-6, 18 hours behind@cablett
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for aecd3f6aexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Kamil Trzciński
added database label
- Resolved by Kamil Trzciński
@felipe_artur would you please review?
requested review from @felipe_artur
@felipe_artur
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- A deleted user
added databasereview pending label
- Resolved by Kamil Trzciński
@dskim_gitlab would you please perform database review? (and please pass to
@ahegyi
when you are ready)
requested review from @dskim_gitlab
added databasereviewed label and removed databasereview pending label
requested review from @ahegyi and removed review request for @dskim_gitlab
requested review from @ayufan
added databaseapproved label and removed databasereviewed label
- Resolved by charlie ablett
enabled an automatic merge when the pipeline for 74d9ef55 succeeds
Hello @cablett
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit 0ff4d972
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)