Skip to content

Creates a test for .zip filenames not in code

Amy Qualls requested to merge aqualls-make-zip-rule into master

What does this MR do?

Tests for filenames ending in .zip that are not wrapped in code tags. Thanks to the new .zip top-level domain name, these could be rendered as links. It's safe to assume they'll be problematic links, because instances of abuse are already in the wild: https://twitter.com/1ZRR4H/status/1657747300339384320

@jamiemaynard, we just chatted about this, and I wanted you to see the initial regex I came up with. There might be a better way to do this regex - @eread or @marcel.amirault are my dependable resources here - but I'd prefer to get a proposal out the door so we can at least start finding instances we should clean up.

Related issues

Related to Wrap .zip names in backticks (!120762 - merged) where I cleaned up the two matches found in the docset.

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.

Merge request reports