Refactor approval_wrapped_rule specs

What does this MR do and why?

This MR refactors the specs for ApprovalWrappedRule to follow the Testing best practices.

More specifically, it touches on the following points:

• Avoid referencing subject in examples. Use a named subject subject(:name), or a let variable instead, so the variable has a contextual name.
• If the subject is never referenced inside examples, then it’s acceptable to define the subject without a name.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #410456 (closed)

changed milestone to %16.0

added Category:Security Policy Management devopsgovern groupsecurity policies sectionsec severity1 typebug workflowverification labels

assigned to @mcavoj

changed the description

added backend label

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Adam Hegyi (@ahegyi) (UTC+2)	Andy Soiron (@Andysoiron) (UTC+2)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added maintenancerefactor typemaintenance labels and removed typebug label

Hi @Andysoiron

Here's the promised follow-up of !120240 (merged) to refactor the specs. Could you please have a look?

requested review from @Andysoiron

removed severity1 label

added 1 commit

• 324de1e3 - Refactor approval_wrapped_rule specs

Compare with previous version

approved this merge request

requested review from @patrickbajao and removed review request for @Andysoiron

@Andysoiron, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 402a50e0 succeeds

merged

mentioned in commit 3a5275e3

added workflowstaging-canary label and removed workflowverification label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added workflowpost-deploy-db-staging label and removed workflowproduction label