Skip to content
Snippets Groups Projects

Enable members_with_shared_group_access feature flag by default

Merged Abdul Wadood requested to merge 377922-enable-ff-members_with_shared_group_access into master
All threads resolved!

What does this MR do and why?

This will calculate the correct access level of shared group members in the /groups/:id/members/all API.

How to set up and validate locally

Follow the steps in the description #377922 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #377922 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #377922 (closed)

  • Contributor

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Abdul Wadood resolved all threads

    resolved all threads

  • Abdul Wadood mentioned in merge request !96543 (merged)

    mentioned in merge request !96543 (merged)

  • mentioned in issue #337623 (closed)

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 181b00d2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 0     | 23    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 181b00d2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 150    | 0      | 0       | 0     | 150   | ✅     |
    | Create           | 260    | 2      | 44      | 0     | 306   | ❌     |
    | Verify           | 105    | 1      | 8       | 0     | 114   | ❌     |
    | Data Stores      | 68     | 0      | 0       | 0     | 68    | ✅     |
    | Manage           | 66     | 0      | 4       | 0     | 70    | ✅     |
    | Growth           | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Govern           | 92     | 0      | 0       | 0     | 92    | ✅     |
    | Monitor          | 16     | 0      | 4       | 0     | 20    | ✅     |
    | Configure        | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Fulfillment      | 4      | 0      | 50      | 0     | 54    | ✅     |
    | Secure           | 4      | 0      | 18      | 0     | 22    | ✅     |
    | Analytics        | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package          | 0      | 0      | 6       | 0     | 6     | ➖     |
    | ModelOps         | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release          | 12     | 0      | 0       | 0     | 12    | ✅     |
    | Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 781    | 3      | 148     | 0     | 932   | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • I see this is enabled fully on gitlab.com, so this MR is safe to merge.

    Screenshot_2023-05-16_at_2.26.13_PM

  • Manoj M J approved this merge request

    approved this merge request

  • :wave: @manojmj, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Manoj M J enabled an automatic merge when the pipeline for b55985ca succeeds

    enabled an automatic merge when the pipeline for b55985ca succeeds

  • merged

  • Manoj M J mentioned in commit 40959998

    mentioned in commit 40959998

  • added workflowstaging label and removed workflowcanary label

  • @abdwdd FYI for when you are back: I merged this MR since it was ready and we had already enabled it on gitlab.com and also close the corresponding issue #377922 (closed)

    Edited by Manoj M J
  • Please register or sign in to reply
    Loading