Enable members_with_shared_group_access feature flag by default
What does this MR do and why?
This will calculate the correct access level of shared group members in the /groups/:id/members/all API.
How to set up and validate locally
Follow the steps in the description #377922 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Closes #377922 (closed)
Merge request reports
Activity
changed milestone to %16.0
assigned to @abdwdd
- A deleted user
added feature flag label
- Resolved by Abdul Wadood
mentioned in issue #377922 (closed)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@1af818c3
mentioned in merge request !96543 (merged)
mentioned in issue #337623 (closed)
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 181b00d2expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 0 | 23 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 181b00d2expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 150 | 0 | 0 | 0 | 150 | ✅ | | Create | 260 | 2 | 44 | 0 | 306 | ❌ | | Verify | 105 | 1 | 8 | 0 | 114 | ❌ | | Data Stores | 68 | 0 | 0 | 0 | 68 | ✅ | | Manage | 66 | 0 | 4 | 0 | 70 | ✅ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | Govern | 92 | 0 | 0 | 0 | 92 | ✅ | | Monitor | 16 | 0 | 4 | 0 | 20 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Fulfillment | 4 | 0 | 50 | 0 | 54 | ✅ | | Secure | 4 | 0 | 18 | 0 | 22 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 12 | 0 | 0 | 0 | 12 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 781 | 3 | 148 | 0 | 932 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
@manojmj
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for b55985ca succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b55985ca
mentioned in commit 40959998
added workflowstaging-canary label and removed workflowfeature-flagged label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
@abdwdd FYI for when you are back: I merged this MR since it was ready and we had already enabled it on gitlab.com and also close the corresponding issue #377922 (closed)
Edited by Manoj M Jadded workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels